Fix/balance warning delay - #440
Merged
johdanike merged 2 commits intoAug 3, 2026
Merged
Conversation
Contributor
|
Please resolve conflicts |
Contributor
|
Please resolve conflicts in existing pr |
…-delay # Conflicts: # components/wallet/BalanceWarning.tsx # pnpm-lock.yaml # tsconfig.tsbuildinfo
|
@Rendevor-ling Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The insufficient-balance banner flickered on modal load: it stored
isVisiblein state (starting false) and toggled it through threecompeting effects, each of which also re-triggered the CSS entrance
animation. On mount the banner painted hidden, then flipped visible a
frame later — a visible race whenever the balance was already known.
Fix at the owner layer (the component) by deriving visibility during
render instead of storing it:
isInsufficient/isVisibleevery render from the balance thehook exposes; a pre-fetched low balance now paints on the first frame.
optimisticBalance(synchronous service cache) over the networkresult when
showImmediatelyis set, so no round-trip is awaited.stored, there is nothing left to race or re-animate.
dismissed.!= nullso an undefined/empty fetch cannever throw during render.
minHeight+ hidden spacer) somounting/unmounting the banner never shifts surrounding layout (CLS 0).
Balance fetching still runs in parallel with mount via the hook's
autoFetch/fetchOnMount path, and the Component → Hook → Service layering
and backend-API data source are preserved.
Closes #300