Repository navigation
kk - #81
kk#81EcosystemNetwork wants to merge 6 commits into
Conversation
|
@EcosystemNetwork is attempting to deploy a commit to the yeeeee Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b96752d194
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: npx netlify-cli deploy --prod --build --site=${{ secrets.NETLIFY_SITE_ID }} --auth=${{ secrets.NETLIFY_AUTH_TOKEN }} | ||
| - run: npm run build | ||
| - name: Deploy to Netlify | ||
| run: npx netlify-cli deploy --prod --dir=.next --site=${{ secrets.NETLIFY_SITE_ID }} --auth=${{ secrets.NETLIFY_AUTH_TOKEN }} |
There was a problem hiding this comment.
Deploy Netlify adapter output, not raw .next folder
This step now runs netlify-cli deploy --prod --dir=.next, which publishes the raw Next build directory as static content; it does not package the app’s server runtime for route handlers. This repo contains Next server endpoints (for example SwarmApp/src/app/api/auth/session/route.ts), so deploying only .next will leave API/SSR paths unavailable in production (404/500). Keep the Netlify build/adaptation path (or deploy generated .netlify artifacts) instead of uploading .next directly.
Useful? React with 👍 / 👎.
| registry.connect(agent1).registerAgent("Alpha", "nlp,code", "ASN-001", 100n) | ||
| ) | ||
| .to.emit(registry, "AgentRegistered") | ||
| .withArgs(agent1.address, "Alpha", "ASN-001", await latestTimestamp()); |
There was a problem hiding this comment.
Avoid pre-tx timestamp in event argument assertions
Using await latestTimestamp() inside .withArgs(...) captures the chain time before the asserted transaction is mined, but the contract emits block.timestamp from the new block. On Hardhat auto-mining this makes these checks fail or flap, and the same pattern is repeated across this file (e.g., lines 148, 218, 332, 380, 386, 433), which can break the contracts test job. Assert with anyValue or read the receipt block timestamp after execution instead.
Useful? React with 👍 / 👎.
No description provided.