-
Notifications
You must be signed in to change notification settings - Fork 1
Claude/hacker news ready v ro2 j #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e88ef74
chore: clean root directory — remove build artifacts, relocate configs
claude 00cb0bf
feat: rewrite README for HN audience, align version to 0.1.0
claude e9a3ccb
chore: add CONTRIBUTING.md, harden CI, simplify deploy workflow
claude c184324
docs: rewrite HN launch materials — honest, no-hype titles and FAQ
claude 7f783ba
chore: pre-flight check — add repo metadata instructions, finalize do…
claude b231e87
chore: remove tracked build artifacts (target/, Cargo.lock)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 CI cache key uses
hashFiles('**/Cargo.lock')but the crate's Cargo.lock is no longer trackedThis PR removed
crates/constraint-theory-core/Cargo.lockfrom git tracking (commit b231e87) but the CI cache key still useshashFiles('**/Cargo.lock'). The only remaining trackedCargo.lockiscrates/gpu-simulation/Cargo.lock, which belongs to a completely different crate. This means the CI cache for constraint-theory-core is keyed off an unrelated crate's dependency graph — it won't bust when constraint-theory-core's dependencies change (e.g., bumpingrand), and will bust unnecessarily when gpu-simulation's dependencies change. The practical impact is low because the crate has zero production dependencies and Cargo detects stale builds regardless of cache, but the cache key is semantically wrong.Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
Playground