Fixes for storefront merge#3
Merged
Merged
Conversation
The rename commit updated the error message and clone paths in storefront/template.rb but missed the URL-parsing regex, which still required the path to end in starter_frontend/template.rb. The installer now generates URLs ending in storefront/template.rb, so every remote install would abort with the 'Could not parse' error. CI never caught this because it applies the template from a local path via SOLIDUS_STOREFRONT_TEMPLATE, which skips the URL parser entirely.
In CI the generated app lives under $RUNNER_TEMP while the repo checkout lives under $GITHUB_WORKSPACE, so the ResultAdapter remap target (SimpleCov.root/../storefront/templates) never exists and the remap never fired. Coverage is still attributed to storefront/templates/** on Codecov because the cobertura report contains app-relative paths (app/controllers/...) that Codecov's path fixing suffix-matches against the repo tree. Verified against the report Codecov ingested for 1f98667. The ERB trailing-line trimming was equally dead: this port of the coverage setup dropped enable_coverage_for_eval, so no .erb files appear in the results at all.
Everything else in .dockerdev derives paths from $APP_USER, so this was the only leftover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.