feat: v2 modules — creational group - #18
Merged
Merged
Conversation
…l_select_builder)
Migrate two creational units to the module template: pattern/ importable
APIs (DocumentFamily families; SelectBuilder -> frozen Query with staged
validation), docs/{fundamentals,implementation,examples}.md, runnable
mini-projects (quarterly report through two families; order analytics on
in-memory sqlite), isolated behavioral tests. Legacy variant files removed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Migrated to the patterns-as-modules template (creational batch 2/2):
- factory_method: pattern/ = the three dodges (inject, class-attribute,
instance-attribute factories); examples/feed_client mirrors
http.client's response_class slot
- prototype: pattern/ = TemplateRegistry over template callables
(partial + dataclasses.replace); examples/report_job_templates
promotes the existing scheduler seed
- singleton: pattern/ = Shared lazy accessor with reset seam;
examples/app_config = process-wide settings behind get_settings()
- docs/{fundamentals,implementation,examples}.md per unit; classic-form
listings absorb the old GoF files; legacy variant files removed
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… feat/v2-creational
…ry_method, prototype, singleton) Assembles feat/v2-creational-1 + -2. Also: ignore agent worktrees; make engine tests shape-robust (synthetic legacy unit fixture; pilot unit as the stable module-shape target) so group migrations don't break them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ide example-imports-pattern check factory_slot trap-safe class-attribute factory; docs no longer teach the descriptor-binding TypeError; every module unit's examples must import its own pattern package (catalog test); legacy variant dispatch + recommend-note tests restored against synthetic fixtures; assorted test tightenings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 (2/6): the five creational units migrated to the module template — abstract_factory (report_renderer), builder (sql_select_builder), factory_method (feed_client on a trap-safe
factory_slot), prototype (report_job_templates), singleton (app_config).Also: engine tests made shape-robust via synthetic legacy/module fixtures; new fleet-wide test that every module unit's examples import their own
pattern/package;.claude/worktrees/gitignored.Reviewed (2 HIGH + 6 MEDIUM findings fixed, re-verified, merge-ready verdict).
make checkgreen: 308 tests, mypy --strict on 235 files.🤖 Generated with Claude Code