[ReenigneArcher]

Description

Quitting a stream can watch an idle gamepad when the same machine supplies both the physical controller and Sunshine's virtual controller. Closing controller references during shell/stream transitions can also leave menu input unresponsive.

• Quit immediately with Back/Select + Black + White (LB + RB) on any connected controller, using digital buttons and no hold timer.
• Read SDL devices on the event thread, preserve queued button transitions per device, and publish synchronized snapshots to the gameplay input sender.
• Retain controller references across render-resource transitions and hand the controller used to dismiss the summary back to the shell.
• Show Stopping stream... promptly and add opt-in controller diagnostics, disabled by default.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

• Windows MSYS2 MinGW64: full host/Xbox build and XBE/ISO packaging passed against master's upstream common library.
• ctest --test-dir cmake-build-release --output-on-failure: 258/258 passed, including the five digital exit-chord regressions.
• Strict Dockle/Doxygen api build passed (394 HTML pages).
• Shared clang-format and git diff --check passed.
• All 17 tracked CMake files pass cmake-lint --line-width 120 --tab-size 4 (cmakelang 0.6.13), matching the CI job. The lint fix only wraps the input-diagnostics definition.
• Confirmed the branch is based directly on current master, changes no dependency pins, and merges cleanly without feat(video): add selectable video codecs #194.
• During implementation, the user confirmed quitting, summary dismissal, menu navigation, and stream restart in xemu with a wired Xbox One controller. That interactive check was not repeated during this branch separation.

Real Xbox hardware was not tested. Hosted CI results are separate from these local checks.

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

• AI tools were used while preparing this PR

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.45%. Comparing base (ff5c45b) to head (9218372).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   63.36%   63.45%   +0.09%     
==========================================
  Files          37       39       +2     
  Lines        5333     5347      +14     
  Branches     2428     2431       +3     
==========================================
+ Hits         3379     3393      +14     
  Misses       1122     1122              
  Partials      832      832              

Flag	Coverage Δ
Linux	63.11% <100.00%> (+0.07%)	⬆️
macOS	50.32% <100.00%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/input/stream_exit.cpp	100.00% <100.00%> (ø)
src/input/stream_exit.h	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5c45b...9218372. Read the comment docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud