Repository navigation
Add Lotus Moss as a built-in map theme - #247
Merged
Merged
Conversation
A third built-in profile next to Default and Valorant: dark moss base, sage detail, warm gold highlight. Bootstrap writes any missing built-in at launch, so existing stores get it too; their custom profiles and default choice stay as they are. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dara liked the Lotus Moss palette from the profile-code mock and asked for it built in. It's now a third built-in map theme beside Default and Valorant.
Colors: base
#18221A, detail#7FA36B, highlight#E3C567.How it ships
immutableBuiltInProfiles.bootstrap()already writes any built-in missing from the store at launch, so existing users get Lotus Moss on their next start. Their custom profiles and their default for new strategies stay as they are.themeProfileIdas an opaque string.Older builds
A strategy set to Lotus Moss and opened in a build without it (an un-updated desktop install, or a backup or .ica restored there) shows Default colors, because that build has no profile with this id. Nothing is lost: the strategy keeps the id and shows Lotus Moss again in a current build.
Reproduction
On main, Map theme lists two built-ins, Default and Valorant.
Verification
flutter analyze lib test: no new issues.flutter test: 1579 passed.Independent of #246 (profile codes). Either can merge first; #246's tests use a different palette, so a Lotus Moss code won't collide with this built-in.
🤖 Generated with Claude Code
No blocking issue was established. Selector rendering remains unverified.
What we checked:
Summary
Adds Lotus Moss as a third built-in map theme. An existing-store check confirmed that startup adds it without changing the tested custom theme, selected default, or preferences. The three new focused tests passed.
T-Rex validation blocked: the updated theme selector could not be checked visually because its test timed out during Hive bootstrap, before rendering.
Reviews (1) · Last reviewed commit: "Add Lotus Moss as a built-in map theme"