Skip to content

remove HAL_Delay(1) for liquid-mod #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niekky wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove HAL_Delay(1) for liquid-mod #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd8302
remove HAL_Delay(1)
niekky Feb 26, 2026
6c48016
fix flash_write timeout: use HAL_GetTick elapsed time instead of iter…
Copilot Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions flash/flash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,8 +731,8 @@ FLASH_STATUS flash_write
HAL_StatusTypeDef hal_status[3]; /* Status codes returned by HAL */
FLASH_STATUS flash_status; /* Status codes returned by flash API */
uint8_t flash_opcode; /* Opcode for flash instructions */
uint32_t timeout; /* Timeout for flash write calls */
uint32_t timeout_ctr; /* Counter to trigger timeout */
uint32_t timeout; /* Timeout for flash write calls (ms) */
uint32_t timeout_start; /* HAL tick at start of flash write */
uint8_t* pbuffer; /* Pointer to data in flash buffer */
uint8_t address_bytes[3]; /* Flash memory address in byte form */

Expand All @@ -743,7 +743,7 @@ uint8_t address_bytes[3]; /* Flash memory address in byte form */
flash_opcode = FLASH_OP_HW_AAI_PROGRAM;
flash_status = FLASH_OK;
timeout = pflash_handle -> num_bytes; /* 1 ms/byte timeout */
timeout_ctr = 0;
timeout_start = HAL_GetTick();
pbuffer = pflash_handle -> pbuffer;
address_to_bytes( pflash_handle -> address, &address_bytes[0] );

Expand Down Expand Up @@ -813,15 +813,10 @@ for ( int i = 2; i < pflash_handle -> num_bytes; i += 2 )
/* Wait for flash to be ready */
while( flash_is_flash_busy() == FLASH_BUSY )
{
if ( timeout_ctr >= timeout )
if ( ( HAL_GetTick() - timeout_start ) >= timeout )
{
return FLASH_TIMEOUT;
}
else
{
timeout_ctr++;
HAL_Delay( 1 );
}
}

/* SPI Transmission */
Expand Down