Skip to content

LoRa Security Fix #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
266-750Balloons merged 2 commits into from
Mar 25, 2026
Merged

LoRa Security Fix #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28b62e0
Added check to prevent receiving messages larger than a specific buff…
Bigmouseears Feb 13, 2026
6f12c77
Added specific error type for buffer overflows.
Bigmouseears Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lora/lora.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,9 @@ LORA_STATUS lora_receive_ready() {
// =============================================================================
// lora_receive: receive a buffer from lora fifo with continuous mode
// =============================================================================
LORA_STATUS lora_receive(uint8_t* buffer_ptr, uint8_t* buffer_len_ptr){
LORA_STATUS lora_receive(uint8_t* buffer_ptr, uint8_t buffer_len, uint8_t* num_bytes_received) {
uint8_t timeout_flag;


// LORA_STATUS rx_done = lora_receive_ready(); // We check if we've received a packet.
// If we haven't received a packet, the output will be similar to lora_receive_ready in that case.
Expand All @@ -423,6 +424,11 @@ LORA_STATUS lora_receive(uint8_t* buffer_ptr, uint8_t* buffer_len_ptr){
uint8_t num_bytes;
LORA_STATUS fifo2_status = lora_read_register(LORA_REG_FIFO_RX_NUM_BYTES, &num_bytes);

if (num_bytes > buffer_len)
{
return LORA_BUFFER_UNDERSIZED;
}

#if defined( TESTRECEIVER )
char buf[255];
int len = sprintf( buf, "Numbytes: %d\r\n", num_bytes );
Expand Down Expand Up @@ -450,7 +456,7 @@ LORA_STATUS lora_receive(uint8_t* buffer_ptr, uint8_t* buffer_len_ptr){
pld_xtr_status = lora_read_register(LORA_REG_FIFO_RW, &packet); // Access LoRA FIFO data buffer pointer
buffer_ptr[i] = packet;
}
*buffer_len_ptr = num_bytes;
*num_bytes_received = num_bytes;
if (pld_xtr_status == LORA_OK ) {
return LORA_OK;
} else {
Expand Down
3 changes: 2 additions & 1 deletion lora/lora.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ typedef enum LORA_STATUS {
LORA_TRANSMIT_FAIL,
LORA_RECEIVE_FAIL,
LORA_TIMEOUT_FAIL,
LORA_BUFFER_UNDERSIZED,
LORA_READY,
LORA_WAITING
} LORA_STATUS;
Expand Down Expand Up @@ -165,6 +166,6 @@ LORA_STATUS lora_transmit(uint8_t* buffer_ptr, uint8_t buffer_len);

LORA_STATUS lora_receive_ready();

LORA_STATUS lora_receive(uint8_t* buffer_ptr, uint8_t* buffer_len_ptr);
LORA_STATUS lora_receive(uint8_t* buffer_ptr, uint8_t buffer_len, uint8_t* num_bytes_received);

#endif