State Estimations & Telemetry Updates - #47
Open
ETSells wants to merge 10 commits into
Open
Conversation
24 tasks
ETSells
marked this pull request as ready for review
July 11, 2026 19:32
…-read-fix Fix BMM150 blocking magnetometer read
ETSells
commented
Jul 19, 2026
ETSells
left a comment
ETSells
left a comment
Member
Author
There was a problem hiding this comment.
stamp. good to go imho. telem side needs review
NArmistead
approved these changes
Jul 20, 2026
NArmistead
left a comment
NArmistead
left a comment
Contributor
There was a problem hiding this comment.
Honestly this looks good and I don't really have much to say. maybe see if @266-750Balloons can also take a look since I don't know a ton about lora
Comment on lines
+34
to
+40
| #include "led.h" | ||
| #elif defined( GROUND_STATION ) | ||
| #include "sdr_pin_defines_A0005.h" | ||
| #include "led.h" | ||
| #elif defined( A0010 ) | ||
| #include "sdr_pin_defines_A0010.h" | ||
| #include "led.h" |
Contributor
There was a problem hiding this comment.
nit: led.h include could go under project includes
| #include "main.h" | ||
|
|
||
| /*------------------------------------------------------------------------------ | ||
| Global Variables |
Contributor
There was a problem hiding this comment.
nit: these are all static variables but I don’t think we have a standard for what goes under “static variables” vs “global variables”
Comment on lines
+148
to
+151
| // ETS TEMP: Test | ||
| // telemetry_get_next_message(); | ||
| // lora_transmit( &payload, sizeof( TELEMETRY_MESSAGE ) ); | ||
| // return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Monster PR batching issues from Epic SunDevilRocketry/Flight-Computer-Firmware#293 dealing with Telemetry and State Estimations to consolidate testing effort.
Issue Link
No subtasks linked to driver.
Parent: SunDevilRocketry/Flight-Computer-Firmware#301
Testing
Test fails in CI are due to an inability to check out the appropriate parent ref. These issues are fixed in the flight-computer-firmware version of the driver runner.
Other
To be cross-reviewed by @ETSells and @NArmistead
Reviewer Checklist
Standards
Error Handling
Memory
Performance