Skip to content

fix: add installing requirements and SDECv2 as a package - #69

Merged
ETSells merged 4 commits into
ES/lint-cifrom
JH/lint-ci-fix
May 7, 2026
Merged

fix: add installing requirements and SDECv2 as a package#69
ETSells merged 4 commits into
ES/lint-cifrom
JH/lint-ci-fix

Conversation

@journeyhancock

Copy link
Copy Markdown
Member

No description provided.

@journeyhancock

journeyhancock commented May 7, 2026

Copy link
Copy Markdown
Member Author

@ETSells @Ljmeza95
I made some changed to the pylint configuration. I looked through the original lint failure in Eli's PR and in my opinion the only issue was the import errors, which I fixed by adding

pip install -r requirements.txt
pip install -e .

Then, I added (( code & 35 )) && exit 1 || exit 0 so the lint will only fail on fatal messages, error messages, and pylint failures. So any pylint warning, refactor, or convention flags won't cause the lint to fail. This is configurable by changing the number the exit code gets ANDed with.

@ETSells

ETSells commented May 7, 2026

Copy link
Copy Markdown
Member

Journey my goat

@ETSells
ETSells merged commit c5a7c6d into ES/lint-ci May 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants