Add gravity compensated acceleration and quaternion tests - #304
Open
bjornhbengtsson wants to merge 1 commit into
Open
Add gravity compensated acceleration and quaternion tests#304bjornhbengtsson wants to merge 1 commit into
bjornhbengtsson wants to merge 1 commit into
Conversation
ETSells
requested changes
Jul 22, 2026
ETSells
left a comment
Member
There was a problem hiding this comment.
We'll want to migrate this test to mod.
Member
There was a problem hiding this comment.
cr: If this file lives in mod, its test should too. I can help get the submodule set up if you'd like.
That means this PR may not be needed. We can close it out unmerged once we get that ready.
Contributor
Author
There was a problem hiding this comment.
Moved the math_sdr unit tests into the mod repository and added the SDR test framework as a submodule. The migrated tests pass locally with 26 passes and 0 failures. We can close this PR unmerged as suggested once the mod PR is ready.
18 tasks
NArmistead
reviewed
Jul 25, 2026
NArmistead
left a comment
Contributor
There was a problem hiding this comment.
We'll want to add the mod tests to CI which you can do if you want, and if not, I'll do it at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
modsubmodule with gravity compensated accelerometer processing and adds unit tests for the quaternion vector rotations used by that implementation.Dependency
This PR depends on the corresponding
modPR:SunDevilRocketry/mod#138
Changes
modsubmodule to include gravity compensated acceleration processing.math_sdrunit test target.main.hfor host compilation.Issue Link
github.com/SunDevilRocketry/mod/issues/139
Testing
If a non-automated test was executed that provides an artifact, please attach below (e.g. flash extract data).
Other
Leave any additional notes here
Reviewer Checklist
Standards
Accuracy
Error Handling
Memory
Performance