Skip to content

Add common library for shared functionality - #50

Open
niekky wants to merge 1 commit into
mainfrom
liquids-upgrade
Open

Add common library for shared functionality#50
niekky wants to merge 1 commit into
mainfrom
liquids-upgrade

Conversation

@niekky

@niekky niekky commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

This pull request primarily updates the build configuration and submodules for the project. The main changes add support for a new common module and update the lib and mod submodules to newer versions.

Build system updates:

  • Added common.c from the common module to the list of source files in the app/hotfire/rev5/Makefile, ensuring it is compiled as part of the build.
  • Included the common module's directory in the include path (C_INCLUDES) in the Makefile, so its headers are available during compilation.

Submodule updates:

  • Updated the lib submodule to a newer commit, which may include bug fixes or new features.
  • Updated the mod submodule to a newer commit, likely bringing in changes required for the new common module integration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Integrates a new shared common module into the Hotfire rev5 build by updating the Makefile so the module is compiled and its headers are discoverable.

Changes:

  • Added $(MOD_DIR)/common/common.c to C_SOURCES so it is built into the firmware.
  • Added -I$(MOD_DIR)/common to C_INCLUDES so common headers can be included during compilation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/hotfire/rev5/Makefile
$(UTIL_DIR)/sdr_error.c \
$(MOD_DIR)/commands/commands.c \
$(MOD_DIR)/ignition/ignition.c \
$(MOD_DIR)/common/common.c \

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new C_SOURCES entry has a stray tab / excess whitespace before the line-continuation backslash, unlike the surrounding entries. Please remove the tab and keep spacing consistent to avoid hidden whitespace differences in Makefile edits.

Suggested change
$(MOD_DIR)/common/common.c \
$(MOD_DIR)/common/common.c \

Copilot uses AI. Check for mistakes.
@ETSells

ETSells commented Apr 13, 2026

Copy link
Copy Markdown
Member

@niekky I don't recommend merging this. Common does not exist on the HEAD of mod, and drivers are on an entirely new submodule.

Recommend postponement to after the "potential" hotfire date (even though we both know that's unlikely to happen, it's the right move for stability).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants