Add common library for shared functionality - #50
Conversation
There was a problem hiding this comment.
Pull request overview
Integrates a new shared common module into the Hotfire rev5 build by updating the Makefile so the module is compiled and its headers are discoverable.
Changes:
- Added
$(MOD_DIR)/common/common.ctoC_SOURCESso it is built into the firmware. - Added
-I$(MOD_DIR)/commontoC_INCLUDESso common headers can be included during compilation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $(UTIL_DIR)/sdr_error.c \ | ||
| $(MOD_DIR)/commands/commands.c \ | ||
| $(MOD_DIR)/ignition/ignition.c \ | ||
| $(MOD_DIR)/common/common.c \ |
There was a problem hiding this comment.
This new C_SOURCES entry has a stray tab / excess whitespace before the line-continuation backslash, unlike the surrounding entries. Please remove the tab and keep spacing consistent to avoid hidden whitespace differences in Makefile edits.
| $(MOD_DIR)/common/common.c \ | |
| $(MOD_DIR)/common/common.c \ |
|
@niekky I don't recommend merging this. Common does not exist on the HEAD of mod, and drivers are on an entirely new submodule. Recommend postponement to after the "potential" hotfire date (even though we both know that's unlikely to happen, it's the right move for stability). |
This pull request primarily updates the build configuration and submodules for the project. The main changes add support for a new common module and update the
libandmodsubmodules to newer versions.Build system updates:
common.cfrom thecommonmodule to the list of source files in theapp/hotfire/rev5/Makefile, ensuring it is compiled as part of the build.commonmodule's directory in the include path (C_INCLUDES) in the Makefile, so its headers are available during compilation.Submodule updates:
libsubmodule to a newer commit, which may include bug fixes or new features.modsubmodule to a newer commit, likely bringing in changes required for the newcommonmodule integration.