Document local development and Keycloak setup#84
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b26e9177f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - ".sonarcloud.properties" | ||
| - ".github/dependabot.yml" | ||
| - ".github/workflows/**.yml" | ||
| - ".github/workflows/workflow.yml" |
There was a problem hiding this comment.
When a PR changes .github/workflows/documentation.yml, this narrowed path filter prevents the CI/CD workflow's actionlint job from running; I checked the new documentation workflow and it only runs markdownlint, so syntax or GitHub Actions expression errors in that workflow can be merged without the repository's workflow lint gate that previously covered .github/workflows/**.yml.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Added a dedicated GitHub Actions lint workflow that runs whenever any workflow file changes.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b26e9177f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - ".sonarcloud.properties" | ||
| - ".github/dependabot.yml" | ||
| - ".github/workflows/**.yml" | ||
| - ".github/workflows/workflow.yml" |
There was a problem hiding this comment.
When a PR changes only another workflow such as .github/workflows/documentation.yml, this narrowed path filter prevents the CI/CD workflow's existing actionlint job from starting; the new documentation workflow only runs markdownlint, so future edits to that workflow no longer get the repository's Actions lint check. Keep the broader workflow glob here, or add an actionlint job to the documentation workflow for workflow-file changes.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Added a dedicated GitHub Actions lint workflow that covers every workflow file change while keeping application CI scoped.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 314cb63293
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - ".sonarcloud.properties" | ||
| - ".github/dependabot.yml" | ||
| - ".github/workflows/**.yml" | ||
| - ".github/workflows/workflow.yml" |
There was a problem hiding this comment.
When a PR changes only one of the new workflow files, such as .github/workflows/documentation.yml or .github/workflows/actions-lint.yml, this path filter no longer starts the CI/CD workflow unless workflow.yml is also touched. The replacement actions-lint workflow only runs actionlint, so the existing Gitleaks and other validation gates in this workflow are skipped for workflow-only PRs; include all workflow files here or move those gates to a workflow that still watches them.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Added secret scanning to the dedicated workflow checks. Workflow-only changes now run both Gitleaks and actionlint without triggering unrelated application tests.
|
@codex review |
|
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
.envValidation
docs/docker compose config