Repository navigation
fix: treat reading a symbolic ref as history-neutral in the conventions replay - #28
Merged
Merged
Conversation
…ns replay git symbolic-ref with one ref only reads it, but the replay classed every symbolic-ref as unknown and failed closed. A v8 trial on GPT-6.1 Sol that branched, committed and named its file correctly scored conventions 0 because it first asked what origin/HEAD pointed at. Writing or deleting a ref still fails closed. Replaying all 42 recorded convention trials changes only that one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
git symbolic-ref <ref>(with options such as--quietor--short) is classified as neutral in the conventions replay. A second positional argument or-d/--delete, which can moveHEAD, still fails closed.Why
The conventions criterion replays Git commands from the trajectory and fails when it cannot determine history. It treated every
symbolic-refas unknown. A Studio Moser v8 trial on GPT-6.1 Sol ranbefore creating
style/pricing-card-copy-spacing, committingstyle: update pricing card copy and spacingand addingPricing Card Notes.md. The verifier printedconventions: Git history or created files could not be determinedand scored 0 for a trial that followed every convention.Testing
Two new cases: the read form is accepted, the write form still fails closed. Replaying the fixed checker over all 42 recorded convention trials changes exactly one score, the trial above; no published result changes.
Workflow_Criteria.pyis an input to the verifier image, so its digest changes for new runs.🤖 Generated with Claude Code