Fiml meanstructure argument#304
Merged
Maximilian-Stefan-Ernst merged 3 commits intodevelfrom Feb 13, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+38
to
+40
| throw(ArgumentError( | ||
| "You set `meanstructure = true`, but your model specification contains no mean parameters." | ||
| )) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| throw(ArgumentError( | |
| "You set `meanstructure = true`, but your model specification contains no mean parameters." | |
| )) | |
| throw( | |
| ArgumentError( | |
| "You set `meanstructure = true`, but your model specification contains no mean parameters.", | |
| ), | |
| ) |
Comment on lines
+43
to
+45
| throw(ArgumentError( | ||
| "If your model specification contains mean parameters, you have to set `Sem(..., meanstructure = true)`." | ||
| )) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| throw(ArgumentError( | |
| "If your model specification contains mean parameters, you have to set `Sem(..., meanstructure = true)`." | |
| )) | |
| throw( | |
| ArgumentError( | |
| "If your model specification contains mean parameters, you have to set `Sem(..., meanstructure = true)`.", | |
| ), | |
| ) |
| "If your model specification contains mean parameters, you have to set `Sem(..., meanstructure = true)`." | ||
| )) | ||
| end | ||
| end No newline at end of file |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end | |
|
|
||
| function SemFIML(; observed::SemObservedMissing, specification, kwargs...) | ||
| function SemFIML(; observed::SemObservedMissing, implied, specification, kwargs...) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+49
to
+51
| throw(ArgumentError( | ||
| "Full information maximum likelihood (FIML) can only be used with a meanstructure. | ||
| Did you forget to set `Sem(..., meanstructure = true)`?")) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| throw(ArgumentError( | |
| "Full information maximum likelihood (FIML) can only be used with a meanstructure. | |
| Did you forget to set `Sem(..., meanstructure = true)`?")) | |
| throw( | |
| ArgumentError( | |
| "Full information maximum likelihood (FIML) can only be used with a meanstructure. | |
| Did you forget to set `Sem(..., meanstructure = true)`?", | |
| ), | |
| ) |
| observed_var_prefix::Union{Symbol, AbstractString} = :obs, | ||
| kwargs..., | ||
| ) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+47
to
+56
| throw(ArgumentError( | ||
| "Your dataset contains missing values. | ||
| Remove missing values or use full information maximum likelihood (FIML) estimation. | ||
| A FIML model can be constructed with | ||
| Sem( | ||
| ..., | ||
| observed = SemObservedMissing, | ||
| loss = SemFIML, | ||
| meanstructure = true | ||
| )")) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| throw(ArgumentError( | |
| "Your dataset contains missing values. | |
| Remove missing values or use full information maximum likelihood (FIML) estimation. | |
| A FIML model can be constructed with | |
| Sem( | |
| ..., | |
| observed = SemObservedMissing, | |
| loss = SemFIML, | |
| meanstructure = true | |
| )")) | |
| throw( | |
| ArgumentError( | |
| "Your dataset contains missing values. | |
| Remove missing values or use full information maximum likelihood (FIML) estimation. | |
| A FIML model can be constructed with | |
| Sem( | |
| ..., | |
| observed = SemObservedMissing, | |
| loss = SemFIML, | |
| meanstructure = true | |
| )", | |
| ), | |
| ) |
|
|
||
| @testset "Sem(implied=$impliedtype, loss=$losstype)" for impliedtype in (RAM, RAMSymbolic), | ||
| losstype in (SemML, SemWLS) | ||
| @testset "Sem(implied=$impliedtype, loss=SemML)" for impliedtype in (RAM, RAMSymbolic) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @testset "Sem(implied=$impliedtype, loss=SemML)" for impliedtype in (RAM, RAMSymbolic) |
| @test @inferred(nsamples(model)) == nsamples(obs) | ||
| end | ||
|
|
||
| @testset "Sem(implied=RAMSymbolic, loss=SemWLS)" begin |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @testset "Sem(implied=RAMSymbolic, loss=SemWLS)" begin |
| semloss = loss(model).functions[1] | ||
| @test semloss isa SemWLS | ||
|
|
||
| @test @inferred(nsamples(model)) == nsamples(obs) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test @inferred(nsamples(model)) == nsamples(obs) | |
| end | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.