Documentation/refactor semopt api#301
Closed
Maximilian-Stefan-Ernst wants to merge 39 commits intodevelfrom
Closed
Documentation/refactor semopt api#301Maximilian-Stefan-Ernst wants to merge 39 commits intodevelfrom
Maximilian-Stefan-Ernst wants to merge 39 commits intodevelfrom
Conversation
This reverts commit 9729819.
This reverts commit 81a4bd9.
This reverts commit f0df653.
It is a simple and intuitive syntax and avoids declaring new types. Also allow specifying default constraint tolerance as `constraint_tol`.
use SemOptimizer(engine = :NLopt) instead of SemOptimizerNLopt() as this is a more universal scheme
It works around docstring errors during SemOptimizer{:E} parsing.
Instead of engine-specific subtype as it might be not available in the user session.
since it moved from struct to ctor
return the type that implements SemOptimizer{engine}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ### Constructor | ||
| ############################################################################################ | ||
|
|
||
| """ |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| """ | |
| !isa(inequality_constraints, NamedTuple) || |
|
|
||
| # fallback optimizer constructor when the engine E is not supported | ||
| SemOptimizer(::Val{E}, args...; kwargs...) where {E} = throw_engine_error(E) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| fit(SemOptimizer(; engine, kwargs...), model; start_val, kwargs...) |
Comment on lines
+59
to
+60
| Returns a vector of optimizer engines supported by the `engine` keyword argument of | ||
| the [`SemOptimizer`](@ref) constructor. |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Returns a vector of optimizer engines supported by the `engine` keyword argument of | |
| the [`SemOptimizer`](@ref) constructor. | |
| prepare_start_params(start_val, model::AbstractSem; kwargs...) = start_val(model; kwargs...) |
|
Docs can be previewed here: https://structuralequationmodels.github.io/StructuralEquationModels.jl/previews/PR301 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.