-
Notifications
You must be signed in to change notification settings - Fork 0
feat: CDP attach mode — observe any DevTools-protocol browser #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
69c461f
docs: plan CDP attach mode
Steel-tech 6e5ea40
feat(cdp): zero-dep DevTools protocol client with discovery and flat …
Steel-tech f4ccd01
feat(cdp): Renderer-facing attach backend with pinned-target policy
Steel-tech 6d60a9d
feat(attach): CDP backend arbitration, frame pipeline, and ownership …
Steel-tech 0f74cd2
feat(attach): event-driven console feed with OOPIF coverage and repla…
Steel-tech 7064757
feat(attach): entry affordances, link handoff, and endpoint hygiene
Steel-tech 06931ec
docs: document CDP attach mode, guarantees, and the a key
Steel-tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
consoleTieris not user-settable.The text tells the reader to set
consoleTiertolog-only.consoleTieris only an option ofmakeCdpBrowser, and the renderer callsmakeCdpBrowser(endpoint)with no options at bin/renderer.mjs lines 568 and 778. No environment variable or config file reaches it. Either expose it (for exampleHERDR_BROWSER_CDP_CONSOLE_TIERplus acdp-console-tierconfig file) or describe the current behavior without an instruction the reader cannot perform.🤖 Prompt for AI Agents