Conversation
Bumps the js-yaml override from 4.3.1 to ^4.3.2, closing GHSA-2883-xcg3-v3hh (maxTotalMergeKeys does not limit CPU use for empty merge sources). js-yaml is transitive only: electron-updater pulls it in for parsing the auto-update feed, and electron-builder and eslint's @eslint/eslintrc pull it in for build and lint tooling. The launcher's own code never imports js-yaml directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The
overrides.js-yamlentry inpackage.jsonmoves from the exact pin4.3.1to^4.3.2, closing GHSA-2883-xcg3-v3hh (maxTotalMergeKeys does not limit CPU use for empty merge sources), Dependabot alert 15.Before: every resolved copy of
js-yamlsat at4.3.1, inside the advisory's vulnerable range (>= 4.0.0, < 4.3.2).After: every resolved copy sits at
4.3.2, the first patched version.npm ls js-yaml --allconfirms all five copies (underelectron-builder,electron-updater, andeslint) now resolve to4.3.2.Exposure
js-yamlis a transitive dependency only, pulled in by:electron-updater(runtime dependency), which uses it to parse the auto-update feed YAML files it downloads.electron-builderand eslint's@eslint/eslintrc(dev dependencies), used only during build and lint.The launcher's own code never imports
js-yaml:Those hits are comments explaining why the existing config tests deliberately read YAML files as text instead of importing
js-yaml, to avoid an undeclared dependency. No player-supplied YAML is ever parsed at runtime by RiftLauncher's own code; the only runtime use iselectron-updaterparsing the update feed it fetches from our own release channel.Testing
npm ls js-yaml --all: all resolved copies at4.3.2.npm audit --omit=dev: 0 vulnerabilities (was flagging js-yaml high before the bump).npm audit: 3 moderate, unrelated to this change (@vitest/mockerpath traversal, dev-only, left untouched).npm run typecheck,npm run lint:ci(0 errors),npm run format:check: all clean.npm run test:coverage: 242 test files passed, 4461 tests passed, 2 skipped.npm run build: electron-vite build succeeded.main is the default branch Dependabot watches, so alert 15 closes once this reaches main with the next promotion.