fix(bootstrap): rebuild incomplete decompile cache - #118
Merged
Merged
Conversation
Zaldaryon
marked this pull request as ready for review
September 23, 2026 20:21
Zaldaryon
force-pushed
the
fix/incomplete-decompile-cache
branch
from
September 23, 2026 20:26
7586bfe to
9f822fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116
Bootstrap previously accepted an empty
build/snapshot/VintagestoryLibdirectory as a completed decompile. Bash and PowerShell now validate decompile manifests against the source DLL SHA-256 and ILSpy version, and require a project file plus C# source files before marking the cache complete. Linux and Windows CI seed an incomplete cache directory before bootstrap.Validation:
make buildmake test(733 passed, 34 skipped; Launcher.Tests 21 passed)make check-patches(68 applied, 50 Cecil, 0 conflicts)make check-shaders