Bypass execution policy and skip profile when launching PowerShell in ScriptBuildDriver - #107
Merged
Merged
Conversation
… ScriptBuildDriver Windows client machines default to the Restricted PowerShell execution policy, which prevents ScriptBuildDriver from executing bootstrap.ps1 and package.ps1 during source builds. Pass -NoProfile -ExecutionPolicy Bypass to PowerShell invocations on Windows, matching SdkInstaller and install-windows.cmd. Update the build layer command tests to assert the execution policy flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Windows client installations configure the PowerShell execution policy to Restricted by default. When ScriptBuildDriver executes bootstrap.ps1 or package.ps1 during local source builds, it launches PowerShell with
["-File", scriptPath]. Without an explicit execution policy override, Windows PowerShell blocks script execution withSecurityError: UnauthorizedAccess.Fix
Pass
-NoProfileand-ExecutionPolicy Bypassto PowerShell invocations on Windows before-File, matching the convention already established inSdkInstaller.cs,UninstallRegistration.cs, andinstall-windows.cmd. Update the unit test assertions inBuildLayerTests.csto verify the new argument sequence.Verification
Ran the test suite locally: