Skip to content

Add ISO 19005 and ToUnicode/CIDSet FontNormalizer regression tests - #301

Open
balazs-szucs wants to merge 1 commit into
fix/pdfa-pdfx-conformance-and-safetyfrom
test/normalizer-conformance-tests
Open

balazs-szucs wants to merge 1 commit into
fix/pdfa-pdfx-conformance-and-safetyfrom
test/normalizer-conformance-tests

Conversation

@balazs-szucs

Copy link
Copy Markdown
Collaborator

Description of Changes

Adds targeted regression tests in FontNormalizerTest, PdfxMetadataSafetyTest, native/bridge/tests/smoke.cpp, and Rust unit tests verifying ISO 19005 PDF/A, PDF/X metadata safety, ToUnicode synthesis, /CIDSet repair, and width normalization. Locks in conformance and bounds-checking guarantees independently from production fixes.

Changed:


Checklist

General

  • I have read the Contributing Guide
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Notable user-facing changes are recorded under ## [Unreleased] in CHANGELOG.md

Library changes

  • Javadoc covers any new or changed public type or member
  • Public API changes are additive, or .github/workflows/compatibility.yml excludes the break with a reason
  • Version references stay consistent across the README, docs/installation.md, and the POMs

Native or FFM changes

  • Rebuilt the bridge at the stack tip (bash native/build-real.sh)
  • Ran ./gradlew :jpdfium:integrationTest
  • Updated native/bridge/include/jpdfium.h and the ABI notes for any ABI change

Testing

  • Added or updated tests that cover the change
  • ./gradlew :jpdfium:integrationTest passes

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch 3 times, most recently from 72d05f7 to 4a21a0b Compare November 18, 2026 11:37
@balazs-szucs
balazs-szucs force-pushed the fix/pdfa-pdfx-conformance-and-safety branch from bab670b to 5f3ae13 Compare November 18, 2026 19:55
@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch from 4a21a0b to 0bfc640 Compare November 18, 2026 19:55
@balazs-szucs
balazs-szucs force-pushed the fix/pdfa-pdfx-conformance-and-safety branch from 5f3ae13 to af870ff Compare November 18, 2026 20:33
@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch from 0bfc640 to 7ecf110 Compare November 18, 2026 20:33
@balazs-szucs
balazs-szucs force-pushed the fix/pdfa-pdfx-conformance-and-safety branch from af870ff to 853966b Compare November 19, 2026 12:57
@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch 4 times, most recently from d90ffc5 to 35403c8 Compare November 19, 2026 14:04
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch from 35403c8 to 2e9fa98 Compare November 19, 2026 15:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant