Skip to content

Add ISO 19005 and ToUnicode/CIDSet FontNormalizer regression tests - #296

Merged
balazs-szucs merged 1 commit into
fix/pdfa-pdfx-conformance-and-safetyfrom
test/normalizer-conformance-tests
Nov 18, 2026
Merged

balazs-szucs merged 1 commit into
fix/pdfa-pdfx-conformance-and-safetyfrom
test/normalizer-conformance-tests

Conversation

@balazs-szucs

@balazs-szucs balazs-szucs commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description of Changes

Adds targeted regression tests in FontNormalizerTest, PdfxMetadataSafetyTest, native/bridge/tests/smoke.cpp, and Rust unit tests verifying ISO 19005 PDF/A, PDF/X metadata safety, ToUnicode synthesis, /CIDSet repair, and width normalization. Locks in conformance and bounds-checking guarantees independently from production fixes.

Changed:


Checklist

General

  • I have read the Contributing Guide
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Notable user-facing changes are recorded under ## [Unreleased] in CHANGELOG.md

Library changes

  • Javadoc covers any new or changed public type or member
  • Public API changes are additive, or .github/workflows/compatibility.yml excludes the break with a reason
  • Version references stay consistent across the README, docs/installation.md, and the POMs

Native or FFM changes

  • Rebuilt the bridge at the stack tip (bash native/build-real.sh)
  • Ran ./gradlew :jpdfium:integrationTest
  • Updated native/bridge/include/jpdfium.h and the ABI notes for any ABI change

Testing

  • Added or updated tests that cover the change
  • ./gradlew :jpdfium:integrationTest passes

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f2358a9 and 2bb83bd.

Files selected for processing: 4

  • jpdfium/src/test/java/stirling/software/jpdfium/doc/PdfxMetadataSafetyTest.java
  • jpdfium/src/test/java/stirling/software/jpdfium/fonts/FontNormalizerTest.java
  • native/bridge/tests/smoke.cpp
  • native/rust/jpdfium-impl/src/lib.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@balazs-szucs
balazs-szucs added this pull request to stack #298 November 15, 2026 12:00
@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch 3 times, most recently from 30a7f82 to 6fdecb6 Compare November 15, 2026 13:59
@balazs-szucs balazs-szucs reopened this Nov 15, 2026
@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch from 6fdecb6 to 0c8aa50 Compare November 15, 2026 16:54
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
@balazs-szucs
balazs-szucs force-pushed the test/normalizer-conformance-tests branch from 0c8aa50 to 2bb83bd Compare November 18, 2026 01:08
@balazs-szucs
balazs-szucs merged commit 2bb83bd into main Nov 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant