Repository navigation
Extract CJK CMap tables and content-stream scanner into jpdfium_qpdf_cmap.cpp - #291
Open
balazs-szucs wants to merge 1 commit into
Open
balazs-szucs wants to merge 1 commit into
balazs-szucs wants to merge 1 commit into
Conversation
balazs-szucs
requested review from
ConnorYoh,
EthanHealy01,
Frooodle,
jbrunton96 and
reecebrowne
as code owners
November 15, 2026 11:58
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
balazs-szucs
force-pushed
the
refactor/cpp-03-extract-qpdf-cmap
branch
from
November 15, 2026 13:43
bf5ddb0 to
4f57ee1
Compare
balazs-szucs
force-pushed
the
refactor/cpp-03-extract-qpdf-cmap
branch
from
November 15, 2026 16:54
4f57ee1 to
4e0129b
Compare
balazs-szucs
force-pushed
the
refactor/cpp-03-extract-qpdf-cmap
branch
from
November 18, 2026 19:55
4e0129b to
cde5fe4
Compare
balazs-szucs
force-pushed
the
refactor/cpp-03-extract-qpdf-cmap
branch
from
November 18, 2026 20:33
cde5fe4 to
85ea704
Compare
…cmap.cpp Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
balazs-szucs
force-pushed
the
refactor/cpp-03-extract-qpdf-cmap
branch
from
November 19, 2026 12:57
85ea704 to
c5807fc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Extracts Adobe-Japan1/GB1/Korea1 CMap lookup tables and QPDF content-stream usage scanners into
native/bridge/src/jpdfium_qpdf_cmap.cpp. Separating large static CMap data and stream lexers keepsjpdfium_qpdf.cppfocused and maintainable with no behavioral changes.Changed:
FontUsageIndex/usedCidsForFontcontent-stream scanners intonative/bridge/src/jpdfium_qpdf_cmap.cpp.jpdfium_qpdf_cmap.cpptonative/CMakeLists.txt.Checklist
General
## [Unreleased]inCHANGELOG.mdLibrary changes
.github/workflows/compatibility.ymlexcludes the break with a reasondocs/installation.md, and the POMsNative or FFM changes
bash native/build-real.sh)./gradlew :jpdfium:integrationTestnative/bridge/include/jpdfium.hand the ABI notes for any ABI changeTesting
./gradlew :jpdfium:integrationTestpasses