Skip to content

Extract CJK CMap tables and content-stream scanner into jpdfium_qpdf_cmap.cpp - #291

Open
balazs-szucs wants to merge 1 commit into
refactor/cpp-02-extract-font-sharedfrom
refactor/cpp-03-extract-qpdf-cmap
Open

balazs-szucs wants to merge 1 commit into
refactor/cpp-02-extract-font-sharedfrom
refactor/cpp-03-extract-qpdf-cmap

Conversation

@balazs-szucs

@balazs-szucs balazs-szucs commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description of Changes

Extracts Adobe-Japan1/GB1/Korea1 CMap lookup tables and QPDF content-stream usage scanners into native/bridge/src/jpdfium_qpdf_cmap.cpp. Separating large static CMap data and stream lexers keeps jpdfium_qpdf.cpp focused and maintainable with no behavioral changes.

Changed:

  • Move predefined CJK CMap range lookups and FontUsageIndex / usedCidsForFont content-stream scanners into native/bridge/src/jpdfium_qpdf_cmap.cpp.
  • Add jpdfium_qpdf_cmap.cpp to native/CMakeLists.txt.

Checklist

General

  • I have read the Contributing Guide
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Notable user-facing changes are recorded under ## [Unreleased] in CHANGELOG.md

Library changes

  • Javadoc covers any new or changed public type or member
  • Public API changes are additive, or .github/workflows/compatibility.yml excludes the break with a reason
  • Version references stay consistent across the README, docs/installation.md, and the POMs

Native or FFM changes

  • Rebuilt the bridge at the stack tip (bash native/build-real.sh)
  • Ran ./gradlew :jpdfium:integrationTest
  • Updated native/bridge/include/jpdfium.h and the ABI notes for any ABI change

Testing

  • Added or updated tests that cover the change
  • ./gradlew :jpdfium:integrationTest passes

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f149c37 and c5807fc.

Files selected for processing: 4

  • jpdfium/src/test/java/stirling/software/jpdfium/doc/PdfCompressorTest.java
  • native/CMakeLists.txt
  • native/bridge/src/jpdfium_qpdf.cpp
  • native/bridge/src/jpdfium_qpdf_cmap.cpp
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@balazs-szucs
balazs-szucs added this pull request to stack #298 November 15, 2026 12:00
@balazs-szucs
balazs-szucs force-pushed the refactor/cpp-03-extract-qpdf-cmap branch from bf5ddb0 to 4f57ee1 Compare November 15, 2026 13:43
@balazs-szucs
balazs-szucs force-pushed the refactor/cpp-03-extract-qpdf-cmap branch from 4f57ee1 to 4e0129b Compare November 15, 2026 16:54
@balazs-szucs
balazs-szucs force-pushed the refactor/cpp-03-extract-qpdf-cmap branch from 4e0129b to cde5fe4 Compare November 18, 2026 19:55
@balazs-szucs
balazs-szucs force-pushed the refactor/cpp-03-extract-qpdf-cmap branch from cde5fe4 to 85ea704 Compare November 18, 2026 20:33
…cmap.cpp

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
@balazs-szucs
balazs-szucs force-pushed the refactor/cpp-03-extract-qpdf-cmap branch from 85ea704 to c5807fc Compare November 19, 2026 12:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants