Skip to content

Update compression options, strict embed verification, and font repair tests - #284

Open
balazs-szucs wants to merge 1 commit into
refactor/font-15-compress-repairfrom
refactor/font-15b-compress-repair-java
Open

balazs-szucs wants to merge 1 commit into
refactor/font-15-compress-repairfrom
refactor/font-15b-compress-repair-java

Conversation

@balazs-szucs

@balazs-szucs balazs-szucs commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Description of Changes

Wires Java compression options, strict post-embed audit verification, and comprehensive font-repair regression tests on top of the native bridge fixes. Prevents silent partial success during strict embedding and verifies glyph coverage and render parity across Java APIs.

Changed:

  • Update CompressOptions, CompressPreset, PdfCompressor, PdfFontAuditor, and PdfFontEmbedder for strict embed verification and safe defaults.
  • Expand PdfCompressorTest, PdfFontEmbedderRoundTripTest, PdfFontEmbedderTest, FontCoverageTest, and FontNormalizerTest.
  • Record user-facing option and verification notes in CHANGELOG.md.

Checklist

General

  • I have read the Contributing Guide
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Notable user-facing changes are recorded under ## [Unreleased] in CHANGELOG.md

Library changes

  • Javadoc covers any new or changed public type or member
  • Public API changes are additive, or .github/workflows/compatibility.yml excludes the break with a reason
  • Version references stay consistent across the README, docs/installation.md, and the POMs

Native or FFM changes

  • Rebuilt the bridge at the stack tip (bash native/build-real.sh)
  • Ran ./gradlew :jpdfium:integrationTest
  • Updated native/bridge/include/jpdfium.h and the ABI notes for any ABI change

Testing

  • Added or updated tests that cover the change
  • ./gradlew :jpdfium:integrationTest passes

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a965a25 and 6a9b8cc.

Files selected for processing: 11

  • CHANGELOG.md
  • jpdfium/src/main/java/stirling/software/jpdfium/doc/CompressOptions.java
  • jpdfium/src/main/java/stirling/software/jpdfium/doc/CompressPreset.java
  • jpdfium/src/main/java/stirling/software/jpdfium/doc/PdfCompressor.java
  • jpdfium/src/main/java/stirling/software/jpdfium/doc/PdfFontAuditor.java
  • jpdfium/src/main/java/stirling/software/jpdfium/doc/PdfFontEmbedder.java
  • jpdfium/src/test/java/stirling/software/jpdfium/doc/PdfCompressorTest.java
  • jpdfium/src/test/java/stirling/software/jpdfium/doc/PdfFontEmbedderRoundTripTest.java
  • jpdfium/src/test/java/stirling/software/jpdfium/doc/PdfFontEmbedderTest.java
  • jpdfium/src/test/java/stirling/software/jpdfium/fonts/FontCoverageTest.java
  • jpdfium/src/test/java/stirling/software/jpdfium/fonts/FontNormalizerTest.java
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@balazs-szucs
balazs-szucs added this pull request to stack #298 November 15, 2026 12:00
@balazs-szucs
balazs-szucs force-pushed the refactor/font-15b-compress-repair-java branch from 9c77518 to e0d5af6 Compare November 15, 2026 16:50
@balazs-szucs
balazs-szucs force-pushed the refactor/font-15b-compress-repair-java branch from e0d5af6 to e7b3a8d Compare November 18, 2026 19:54
@balazs-szucs
balazs-szucs force-pushed the refactor/font-15b-compress-repair-java branch from e7b3a8d to 86a37f7 Compare November 18, 2026 20:32
…r tests

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
@balazs-szucs
balazs-szucs force-pushed the refactor/font-15b-compress-repair-java branch from 86a37f7 to 6a9b8cc Compare November 19, 2026 12:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant