You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replaces the partial glyph table with the complete official Adobe Glyph List 2.0 dictionary and multi-codepoint AGL sequences. Full AGL coverage eliminates lookup misses for legacy, Cyrillic, and ligature glyph names during ToUnicode synthesis and font replacement.
Changed:
Add native/tools/generate_adobe_glyph_names.py and generate adobe_glyph_names.inc with 4,200+ single-scalar and multi-scalar AGL entries plus reverse Unicode lookup.
Extend jpdfium_font_encoding.h helpers and bundle ADOBE-GLYPHLIST-BSD-3.txt and NOTICE.txt license documentation.
Add native bidirectional AGL lookup and uXXXX checks to native/bridge/tests/smoke.cpp.
The saved review history does not include the base for the last reviewed commit. This saved history cannot establish the base for an incremental review. Comment @coderabbitai full review to establish a new review baseline. No full review was started, and the last reviewed checkpoint was preserved.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
Summary
Summary by CodeRabbit
New Features
Added support for resolving Adobe glyph names that represent multiple Unicode characters.
Added reverse lookup from a Unicode character to its Adobe glyph name.
Bug Fixes
Improved glyph-name parsing: uXXXX names now require uppercase hexadecimal digits, while single-character uniXXXX names continue to accept either case. Unknown glyph names remain unresolved.
The change adds a generator for Adobe glyph-name tables, extends glyph-name and Unicode lookup behavior, and adds smoke checks for the mappings and sequences.
The script parses glyph-list entries, validates mapping counts and sequence width, and writes C++ declarations for single-scalar, sequence, and reverse lookup tables.
The header adds uppercase-only hexadecimal validation for u-prefixed names, Adobe sequence-name lookup, and reverse lookup from a Unicode scalar to a glyph name. BaseEncoding now uses uint8_t as its underlying type.
Smoke checks cover glyph-name and Unicode mappings, unknown and case-sensitive names, and multi-codepoint sequences. The checks run after library initialization.
Possibly related PRs
Stirling-Tools/JPDFium#242: Adds Adobe glyph-name resolution paths that share lookup behavior with this change.
Stirling-Tools/JPDFium#253: Uses Adobe glyph-name handling and the reverse lookup helper in shared font-subsetting and normalization work.
Stirling-Tools/JPDFium#244: Adds Adobe Glyph List data and glyph-name resolution that overlap with this change’s mapping and sequence support.
Change: Feature
Pre-merge checks: 4
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title "Add complete Adobe Glyph List 2.0 table" names the main change: the generated AGL 2.0 mapping table in adobe_glyph_names.inc. The objectives and summary also center on this table and its lo…
Description check
The description follows the repository template's sections (Description of Changes, General, Library changes, Native or FFM changes, Testing) and explains the main change: the full Adobe Glyph List 2.…
Full details: Title check
Explanation
The title "Add complete Adobe Glyph List 2.0 table" names the main change: the generated AGL 2.0 mapping table in adobe_glyph_names.inc. The objectives and summary also center on this table and its lookup helpers. The title omits the reverse lookup helpers, the sequence entries, and the encoding header changes, but those are secondary to the main change.
Full details: Description check
Explanation
The description follows the repository template's sections (Description of Changes, General, Library changes, Native or FFM changes, Testing) and explains the main change: the full Adobe Glyph List 2.0 table, the generator script, the header helpers, the bundled license files, and the smoke tests. Several checklist items are unchecked, and the description does not state whether the public API change is additive. The author also checks 'Rebuilt the bridge' and 'Ran integrationTest' items, which are reported but not verified here. The description says the change adds 4,200+ entries, while the objectives mention a 4,200 entry table, which is consistent. However, the description's 'Closes #' issue reference is missing, and the template's changed-header/ABI note is not addressed.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Review coverage is incomplete: 1 file could not be fully reviewed. Findings from completed review steps are included; see review info for details.
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
⚠️ Outside diff range comments (1)
Minor · Resolve sequence-valued ligature components. · jpdfium_font_encoding.h:164
native/bridge/include/jpdfium_font_encoding.h:164 Minor · Functional Correctness · Quick win
Resolve sequence-valued ligature components.
The new sequence lookup applies only to the whole name. For dalethatafpatah_A, this loop calls the scalar-only helper for dalethatafpatah and returns an empty sequence. Adobe’s mapping requires each component to resolve to a string before concatenation. (github.com)
Resolve each component with the sequence helper and append all its scalars.
Reviewing files that changed from the base of the PR and between 1b74c22 and 12c2dcd.
Files selected for processing: 4
native/bridge/include/jpdfium_font_encoding.h
native/bridge/src/adobe_glyph_names.inc
native/bridge/tests/smoke.cpp
native/tools/generate_adobe_glyph_names.py
Files not fully reviewed because they exceed a per-file size limit: 1
native/bridge/src/adobe_glyph_names.inc
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Review details
Additional context used
Code guidelines: 1
.github/CODERABBIT_REVIEW.md — configured
Path-based instructions: 2
Apply the native ownership, C ABI, C++23, engine integration, memory, and SIMD rules from .github/CODERABBIT_REVIEW.md.
CodeRabbit configuration file
Files:
native/bridge/tests/smoke.cpp
native/bridge/include/jpdfium_font_encoding.h
Source excerpt: These rules apply to maintained source.
[warning] 26-26: for loop variable line overwritten by assignment target
(PLW2901)
[warning] 32-32: Avoid specifying long messages outside the exception class
(TRY003)
[warning] 61-64: Avoid specifying long messages outside the exception class
(TRY003)
[warning] 68-68: Avoid specifying long messages outside the exception class
(TRY003)
Additional comments: 1
native/bridge/include/jpdfium_font_encoding.h: 1
152-152: Data Integrity & Integration
A production path uses the sequence mappings and carries valid sequences into /ToUnicode. The claim that only the smoke test uses them is contradicted.
balazs-szucs
changed the title
Add complete Adobe Glyph List 2.0 mapping table and binary-search helpers
Add complete Adobe Glyph List 2.0 table
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Replaces the partial glyph table with the complete official Adobe Glyph List 2.0 dictionary and multi-codepoint AGL sequences. Full AGL coverage eliminates lookup misses for legacy, Cyrillic, and ligature glyph names during
ToUnicodesynthesis and font replacement.Changed:
native/tools/generate_adobe_glyph_names.pyand generateadobe_glyph_names.incwith 4,200+ single-scalar and multi-scalar AGL entries plus reverse Unicode lookup.jpdfium_font_encoding.hhelpers and bundleADOBE-GLYPHLIST-BSD-3.txtandNOTICE.txtlicense documentation.uXXXXchecks tonative/bridge/tests/smoke.cpp.Checklist
General
## [Unreleased]inCHANGELOG.mdLibrary changes
.github/workflows/compatibility.ymlexcludes the break with a reasondocs/installation.md, and the POMsNative or FFM changes
bash native/build-real.sh)./gradlew :jpdfium:integrationTestnative/bridge/include/jpdfium.hand the ABI notes for any ABI changeTesting
./gradlew :jpdfium:integrationTestpasses