Skip to content

Publish releases to maven.stirlingpdf.com - #180

Merged
balazs-szucs merged 16 commits into
mainfrom
publish-to-r2
Nov 20, 2026
Merged

balazs-szucs merged 16 commits into
mainfrom
publish-to-r2

Conversation

@Frooodle

@Frooodle Frooodle commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Description of Changes

  • Releases now publish to https://maven.stirlingpdf.com (Cloudflare R2) first, since Maven Central now requires a paid Publisher Pro plan for us.
  • Uploads go through the shared Stirling-Tools/maven-r2-publish actions, pinned by SHA; JPDFium no longer carries its own upload scripts.
  • release.yml uses maven-r2-publish/release: stage to staging/JPDFium/<run>/, the six-platform verify against its staging-url, promote the exact staged files only if all pass, then cleanup. Released versions can't be overwritten.
    • dryRun stages and verifies on every platform, then deletes staging without releasing.
    • When verify or promote fails, staging is kept so "Re-run failed jobs" can finish; an interrupted promote resumes.
    • CLI binaries attach to the GitHub release only after promote, from a job that alone has contents: write.
    • The release version is validated (^[0-9A-Za-z._-]+$) and reaches every script through env:.
  • After the R2 release, publish-central sends the same version to Maven Central (auto-release) and verify-central probes it on all six platforms. Both are continue-on-error, so a Central failure never fails the release; uploads to Central run one at a time (central-portal concurrency group).
  • mirror-central-to-r2.yml wraps maven-r2-publish/mirror: versions (all = newest latest, default 5, or a list), destination prefix (empty is the live root), dryRun, and an optional six-platform smoke per copied version. Versions already there are skipped; every file is sha1-checked against Central and against what R2 serves.
  • NativeDownloader runtime downloads, README, install/config/native-loading docs, the example project and CHANGELOG now point at the new repository.
  • Verified:
    • Earlier on this branch: 1.1.6 and 1.2.0 copied from Central to R2 (1.2.0 passed the six-platform verify); a full test release 0.0.0-citest.1 staged, verified, promoted and then deleted; Stirling-PDF resolved JPDFium from R2 with Central blocked and auto-redaction worked in the running app.
    • The shared actions pass 23 end-to-end checks in their own CI against an S3 server: byte-for-byte mirror of 1.0.0 from Central, resume of an interrupted upload and promote, refusal of changed bytes, Maven pre-release ordering.
    • NativeDownloaderTest (15 tests, including the new default-repository test) passes.
    • This branch's real publishAllToR2Staging output went through stage → promote → cleanup locally against that server: 85 of 85 files served unchanged, metadata written for all four modules, staging removed.
  • Not verified yet: the shared actions against real R2, and the Central jobs end to end. Both run on the next real release.
  • Not changed here: snapshot.yml (Central snapshots on every push to main), publish-github-packages.yml, compatibility.yml (baseline from Central), and the Maven Central README badge.
  • After merge: run release.yml with dryRun once to exercise real R2, then mirror-central-to-r2.yml with versions=all to add 1.1.4, 1.1.5, 1.3.0 and 1.3.1; R2 currently has 1.1.6 and 1.2.0.

Checklist

General

  • I have read the Contributing Guide
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Notable user-facing changes are recorded under ## [Unreleased] in CHANGELOG.md

Library changes

  • Javadoc covers any new or changed public type or member
  • Public API changes are additive, or .github/workflows/compatibility.yml excludes the break with a reason
  • Version references stay consistent across the README, docs/installation.md, and the POMs

Native or FFM changes

  • Rebuilt the bridge with bash native/build-real.sh
  • Ran ./gradlew :jpdfium:integrationTest
  • Updated native/bridge/include/jpdfium.h and the ABI notes for any ABI change

Testing

  • Added or updated tests that cover the change
  • ./gradlew test passes

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review
Summary

Summary by CodeRabbit

  • New Features

    • JPDFium artifacts are available from the Stirling Maven repository, now the default source for runtime native downloads. A configurable repository override remains available.
    • Added an option to mirror JPDFium releases from Maven Central, with optional cross-platform smoke tests.
  • Changes

    • Releases are staged and verified in the Stirling Maven repository before promotion and submission to Maven Central.
    • Updated installation guidance and examples to configure the Stirling repository for com.stirling artifacts.

The release workflow stages signed artifacts in R2, verifies them, promotes them when dryRun is false, and submits them to Maven Central. A manual workflow mirrors selected Maven Central releases to R2. Documentation, examples, and native downloads now use the Stirling Maven repository.

Changes: Stirling Maven repository

Layer / File(s) Summary
R2 staging setup
build.gradle.kts
Gradle configures an R2 staging repository for subprojects that apply maven-publish. The publishAllToR2Staging task aggregates subproject publication tasks.
Staged release and verification
.github/scripts/verify-central.sh, .github/workflows/release.yml
The verifier accepts R2 mode and omits Authorization headers when no token is set. The release workflow stages and verifies artifacts, promotes them when dryRun is false, attempts Central publication, and cleans up staging under the configured conditions.
Central mirroring and platform checks
.github/workflows/mirror-central-to-r2.yml
A manual workflow mirrors selected com.stirling:jpdfium releases from Maven Central to R2. Optional smoke checks verify copied versions across six platforms.
Consumer repository configuration
README.md, CHANGELOG.md, docs/*, examples/render-first-page/*, jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java, jpdfium/src/test/java/stirling/software/jpdfium/panama/NativeDownloaderTest.java
Gradle and Maven examples identify the Stirling Maven repository. NativeDownloader uses it by default and retains the configurable repository override. A test checks the default repository URL.

Possibly related PRs

  • Stirling-Tools/JPDFium#182: Both PRs change release dry-run behavior. This PR stages and verifies artifacts in R2; PR #182 publishes to Maven Local and skips verification.

Change: Feature

Merge Risk: Low · previous review 99195

Release publishing is mostly sound. Before relying on it, disable credential persistence and Gradle caching in the signing and attach jobs, and correct the dry-run summary and the blank-version handling on manual dispatch.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title identifies the main change: publishing releases to the Stirling Maven repository.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the template and explains the changes, purpose, testing, and remaining verification. Some checklist items remain unchecked.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 16


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: Stirling-Tools/JPDFium/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 92b14a9a-9131-488a-8842-433b9de197a1
📥 Commits

Reviewing files that changed from the base of the PR and between 5a35fef and 1f13352.

📒 Files selected for processing: 14
  • .github/scripts/maven_metadata.py
  • .github/scripts/upload-to-r2.sh
  • .github/scripts/verify-central.sh
  • .github/workflows/mirror-central-to-r2.yml
  • .github/workflows/release.yml
  • CHANGELOG.md
  • README.md
  • build.gradle.kts
  • docs/configuration.md
  • docs/installation.md
  • docs/native-loading.md
  • examples/render-first-page/README.md
  • examples/render-first-page/build.gradle.kts
  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details
⏰ Context from checks skipped due to timeout: 42
  • GitHub Check: prep-windows-icu
  • GitHub Check: Native bridge libFuzzer (ASan/UBSan, real PDFium)
  • GitHub Check: build-natives (windows-arm64, windows-11-arm)
  • GitHub Check: Restricted-env compat (no execstack + hermetic bundle)
  • GitHub Check: Build & Verify (Compilation) (macos-14)
  • GitHub Check: JMH Benchmarks (FFM Downcall Overhead Gate)
  • GitHub Check: Unit & Integration E2E Tests (Linux x64)
  • GitHub Check: build-natives (linux-arm64, ubuntu-24.04-arm)
  • GitHub Check: GraalVM Native Image Smoke & E2E Test (Linux x64)
  • GitHub Check: Concurrency Stress Tests (Linux x64)
  • GitHub Check: Natural System Libvips & Downstream Integration (Linux x64)
  • GitHub Check: README Quick Start Example (Linux x64)
  • GitHub Check: Musl Native Detection (Alpine)
  • GitHub Check: Build & Verify (Compilation) (windows-latest)
  • GitHub Check: Samples E2E Suite (All 88 Feature Samples)
  • GitHub Check: Publish Maven Dry Run
  • GitHub Check: Build & Verify (Compilation) (ubuntu-latest)
  • GitHub Check: Corpus + integration e2e
  • GitHub Check: build-natives (darwin-x64, macos-15-intel)
  • GitHub Check: build-natives (linux-x64, ubuntu-latest)
  • GitHub Check: Bundle verify (symbols, RPATH, linkage, sizes)
  • GitHub Check: build-natives (darwin-arm64, macos-14)
  • GitHub Check: Samples E2E (88 features via RunAllSamples)
  • GitHub Check: Robustness, Leak & Determinism Tests (Linux x64)
  • GitHub Check: CLI correctness & no-corruption tests
  • GitHub Check: build-natives (windows-x64, windows-latest)
  • GitHub Check: Javadoc builds cleanly
  • GitHub Check: Shellcheck (scripts + native/*.sh)
  • GitHub Check: Flaky-test guard (3× rerun)
  • GitHub Check: Module descriptor integrity
  • GitHub Check: CodeQL Analysis (c-cpp)
  • GitHub Check: JaCoCo coverage (non-blocking ratchet)
  • GitHub Check: FFM layout vs pinned PDFium headers
  • GitHub Check: OSV vulnerability scan
  • GitHub Check: Java - SpotBugs + Checkstyle + PMD + Spotless
  • GitHub Check: CodeQL (c-cpp)
  • GitHub Check: CodeQL Analysis (java-kotlin)
  • GitHub Check: C++ - clang-tidy + cppcheck + clang-format
  • GitHub Check: Corpus (generate + native)
  • GitHub Check: Public API compatibility (japicmp vs last release)
  • GitHub Check: CodeQL (java-kotlin)
  • GitHub Check: Outdated dependencies report
🧰 Additional context used
📚 Code guidelines: 1
.github/CODERABBIT_REVIEW.md — configured
📓 Path-based instructions: 2
Apply the Java 25 and FFM rules from .github/CODERABBIT_REVIEW.md.

⚙️ CodeRabbit configuration file

Files:

  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java
Source excerpt: Use imports rather than package-qualified type names in method bodies and signatures.

📄 CodeRabbit inference engine (.github/CODERABBIT_REVIEW.md)

Files:

  • README.md
  • examples/render-first-page/README.md
  • examples/render-first-page/build.gradle.kts
  • docs/configuration.md
  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java
  • docs/native-loading.md
  • CHANGELOG.md
  • docs/installation.md
  • build.gradle.kts
🪛 actionlint (1.7.12)
.github/workflows/mirror-central-to-r2.yml

[error] 28-28: shellcheck reported issue in this script: SC2012:info:9:15: Use find instead of ls to better handle non-alphanumeric filenames

(shellcheck)

.github/workflows/release.yml

[error] 1068-1068: shellcheck reported issue in this script: SC2086:info:2:81: Double quote to prevent globbing and word splitting

(shellcheck)

🪛 LanguageTool
docs/native-loading.md

[locale-violation] ~11-~11: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ... time it runs and reuse the cached copy afterwards. This is disabled by default. Enable i...

(AFTERWARDS_US)

🪛 Ruff (0.16.9)
.github/scripts/maven_metadata.py

[error] 29-29: Using xml to parse untrusted data is known to be vulnerable to XML attacks; use defusedxml equivalents

(S314)

🪛 zizmor (1.30.1)
.github/workflows/mirror-central-to-r2.yml

[warning] 24-24: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[warning] 76-76: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[warning] 3-8: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting

(concurrency-limits)

.github/workflows/release.yml

[info] 961-961: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 962-962: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[info] 988-988: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 990-990: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 1057-1057: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[warning] 1060-1060: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[info] 1086-1086: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 1086-1086: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)

🔇 Additional comments: 5
.github/workflows/release.yml: 2

1042-1042: Gate promote on a successful verify-staging result.

needs: [publish, verify-staging] runs promote only when both succeed, because the default condition is success(). The explicit if: ${{ !inputs.dryRun }} replaces that default. A custom if without a status function drops the implicit success() check only when it contains a status function. Here it has none, so success() is still applied. No change is required.


997-997: Fix the verify-staging condition so a tag-less dispatch without a version does not skip verification and promote.

verify-staging runs only for tags or when inputs.version is set. On a workflow_dispatch without a version, verify-staging is skipped. promote then does not run, because a skipped dependency fails success(). The result is safe. Confirm that this is intended.

Also applies to: 1042-1042

build.gradle.kts: 1

330-350: LGTM!

.github/scripts/verify-central.sh: 2

5-9: LGTM!

Also applies to: 25-29, 264-264


169-182: 🔒 Security & Privacy

The Authorization credentials are scoped to the staging maven repository. The separate mavenCentral declaration has no credentials. In r2 mode, PORTAL_TOKEN and the exported VERIFY_TOKEN are empty, so Gradle does not configure authentication for R2. No change is needed.

Comment thread .github/scripts/maven_metadata.py Resolved
Comment thread .github/scripts/maven_metadata.py Resolved
Comment thread .github/scripts/upload-to-r2.sh Resolved
Comment thread .github/scripts/upload-to-r2.sh Resolved
Comment thread .github/scripts/upload-to-r2.sh Resolved
Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
Comment thread docs/native-loading.md Resolved
Comment thread docs/native-loading.md Resolved
# Conflicts:
#	.github/workflows/release.yml
# Conflicts:
#	.github/workflows/release.yml
#	CHANGELOG.md

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Note

Follow-up findings are listed below so you can review them separately from inline comments.

Follow-ups (2)
Minor (2)
Minor · Reject a blank version on manual dispatch before staging. · release.yml:1093-1094

.github/workflows/release.yml:1093-1094
Minor · Functional Correctness · Quick win

Reject a blank version on manual dispatch before staging.

On a manual run with no version, the publish job's Resolve version step falls back to the branch name, such as main. It then stages that value. verify-staging and promote are skipped, and cleanup-staging deletes the staging copy, so the run ends without a release or an error. The version input description says the fallback applies only "on tag push".

Suggested fix
       - name: Resolve version
         id: v
         env:
           INPUT_VERSION: ${{ inputs.version }}
         run: |
+          if [ "${{ github.event_name }}" = "workflow_dispatch" ] && [ -z "$INPUT_VERSION" ]; then
+            echo "ERROR: the version input is required for manual dispatch"
+            exit 1
+          fi
           if [ "${{ github.event_name }}" = "workflow_dispatch" ] && [ -n "$INPUT_VERSION" ]; then
             VERSION="$INPUT_VERSION"
           else
Minor · Correct the publish summary on dry runs. Promotion to the root does not run. · release.yml:1040

.github/workflows/release.yml:1040
Minor · Functional Correctness · Quick win

Correct the publish summary on dry runs. Promotion to the root does not run.

The Summary step in the publish job writes "released to the root once every platform verifies" on every run. It has no if: guard. On a dry run, the promote job is skipped (if: ${{ !inputs.dryRun }}). The line therefore describes a promotion that does not happen.

Write a dry-run message in that case. Keep the existing line for other runs.

Suggested fix
-          echo "https://maven.stirlingpdf.com/staging/${{ github.run_id }}/ - released to the root once every platform verifies." >> $GITHUB_STEP_SUMMARY
+          if [ "${{ inputs.dryRun }}" = "true" ]; then
+            echo "Dry run: this run does not promote to the public root." >> $GITHUB_STEP_SUMMARY
+          else
+            echo "https://maven.stirlingpdf.com/staging/${{ github.run_id }}/ - released to the root once every platform verifies." >> $GITHUB_STEP_SUMMARY
+          fi
Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1f13352 and 9baa723.

Files selected for processing: 4
  • .github/workflows/release.yml
  • CHANGELOG.md
  • build.gradle.kts
  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Review details
Context from checks skipped due to timeout: 43
  • GitHub Check: Build & Verify (Compilation) (ubuntu-latest)
  • GitHub Check: Robustness, Leak & Determinism Tests (Linux x64)
  • GitHub Check: Publish Maven Dry Run
  • GitHub Check: JMH Benchmarks (advisory)
  • GitHub Check: Concurrency Stress Tests (Linux x64)
  • GitHub Check: GraalVM Native Image Smoke & E2E Test (Linux x64)
  • GitHub Check: Build & Verify (Compilation) (windows-latest)
  • GitHub Check: README Quick Start Example (Linux x64)
  • GitHub Check: Build & Verify (Compilation) (macos-15)
  • GitHub Check: Samples E2E Suite (All 88 Feature Samples)
  • GitHub Check: Unit & Integration E2E Tests (Linux x64)
  • GitHub Check: Natural System Libvips & Downstream Integration (Linux x64)
  • GitHub Check: Musl Native Detection (Alpine)
  • GitHub Check: Shellcheck (scripts + native/*.sh)
  • GitHub Check: JaCoCo coverage (non-blocking ratchet)
  • GitHub Check: build-natives (windows-x64, windows-latest)
  • GitHub Check: build-natives (windows-arm64, windows-11-arm)
  • GitHub Check: build-natives (darwin-x64, macos-15-intel)
  • GitHub Check: build-natives (darwin-arm64, macos-15)
  • GitHub Check: Javadoc builds cleanly
  • GitHub Check: build-natives (linux-arm64, ubuntu-24.04-arm)
  • GitHub Check: build-natives (linux-x64, ubuntu-latest)
  • GitHub Check: Bundle verify (symbols, RPATH, linkage, sizes)
  • GitHub Check: CLI correctness & no-corruption tests
  • GitHub Check: Java - SpotBugs + Checkstyle + PMD + Spotless
  • GitHub Check: prep-windows-icu
  • GitHub Check: Corpus (generate + native)
  • GitHub Check: Restricted-env compat (no execstack + hermetic bundle)
  • GitHub Check: C++ - clang-tidy + cppcheck + clang-format
  • GitHub Check: Native bridge libFuzzer (ASan/UBSan, real PDFium)
  • GitHub Check: CodeQL (c-cpp)
  • GitHub Check: OSV vulnerability scan
  • GitHub Check: Samples E2E (88 features via RunAllSamples)
  • GitHub Check: CodeQL Analysis (java-kotlin)
  • GitHub Check: Flaky-test guard (3× rerun)
  • GitHub Check: CodeQL (java-kotlin)
  • GitHub Check: Gradle lockfile freshness
  • GitHub Check: CodeQL Analysis (c-cpp)
  • GitHub Check: Outdated dependencies report
  • GitHub Check: Corpus + integration e2e
  • GitHub Check: Public API compatibility (japicmp vs last release)
  • GitHub Check: Module descriptor integrity
  • GitHub Check: FFM layout vs pinned PDFium headers
Additional context used
Code guidelines: 1
.github/CODERABBIT_REVIEW.md — configured
Path-based instructions: 2
Apply the Java 25 and FFM rules from .github/CODERABBIT_REVIEW.md.

CodeRabbit configuration file

Files:

  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java
Source excerpt: These rules apply to maintained source.

CodeRabbit inference engine (.github/CODERABBIT_REVIEW.md)

Files:

  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java
  • build.gradle.kts
  • CHANGELOG.md
  • .github/workflows/release.yml
actionlint (1.7.12)
.github/workflows/release.yml

[error] 1120-1120: shellcheck reported issue in this script: SC2086:info:2:81: Double quote to prevent globbing and word splitting

(shellcheck)

zizmor (1.30.1)
.github/workflows/release.yml

[info] 1003-1003: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 1004-1004: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[info] 1038-1038: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 1040-1040: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 1109-1109: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[warning] 1112-1112: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[info] 1138-1138: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)


[warning] 1138-1138: code injection via template expansion (template-injection): may expand into attacker-controllable code

(template-injection)

Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4931c38 and 99195c7.

Files selected for processing: 6

  • .github/workflows/mirror-central-to-r2.yml
  • .github/workflows/release.yml
  • docs/installation.md
  • docs/native-loading.md
  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java
  • jpdfium/src/test/java/stirling/software/jpdfium/panama/NativeDownloaderTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Review details

Context from checks skipped due to timeout: 43

  • GitHub Check: Robustness, Leak & Determinism Tests (Linux x64)
  • GitHub Check: JMH Benchmarks (advisory)
  • GitHub Check: Build & Verify (Compilation) (windows-latest)
  • GitHub Check: GraalVM Native Image Smoke & E2E Test (Linux x64)
  • GitHub Check: Concurrency Stress Tests (Linux x64)
  • GitHub Check: Samples E2E Suite (All 88 Feature Samples)
  • GitHub Check: Musl Native Detection (Alpine)
  • GitHub Check: Natural System Libvips & Downstream Integration (Linux x64)
  • GitHub Check: Unit & Integration E2E Tests (Linux x64)
  • GitHub Check: Build & Verify (Compilation) (ubuntu-latest)
  • GitHub Check: Build & Verify (Compilation) (macos-15)
  • GitHub Check: Publish Maven Dry Run
  • GitHub Check: README Quick Start Example (Linux x64)
  • GitHub Check: FFM layout vs pinned PDFium headers
  • GitHub Check: CodeQL (java-kotlin)
  • GitHub Check: Module descriptor integrity
  • GitHub Check: Corpus + integration e2e
  • GitHub Check: prep-windows-icu
  • GitHub Check: CodeQL (c-cpp)
  • GitHub Check: Javadoc builds cleanly
  • GitHub Check: Public API compatibility (japicmp vs last release)
  • GitHub Check: Samples E2E (88 features via RunAllSamples)
  • GitHub Check: Restricted-env compat (no execstack + hermetic bundle)
  • GitHub Check: CLI correctness & no-corruption tests
  • GitHub Check: Flaky-test guard (3× rerun)
  • GitHub Check: JaCoCo coverage (non-blocking ratchet)
  • GitHub Check: C++ - clang-tidy + cppcheck + clang-format
  • GitHub Check: CodeQL Analysis (c-cpp)
  • GitHub Check: Native bridge libFuzzer (ASan/UBSan, real PDFium)
  • GitHub Check: OSV vulnerability scan
  • GitHub Check: build-natives (darwin-arm64, macos-15)
  • GitHub Check: Corpus (generate + native)
  • GitHub Check: build-natives (windows-arm64, windows-11-arm)
  • GitHub Check: build-natives (linux-arm64, ubuntu-24.04-arm)
  • GitHub Check: build-natives (darwin-x64, macos-15-intel)
  • GitHub Check: build-natives (windows-x64, windows-latest)
  • GitHub Check: Shellcheck (scripts + native/*.sh)
  • GitHub Check: Gradle lockfile freshness
  • GitHub Check: Bundle verify (symbols, RPATH, linkage, sizes)
  • GitHub Check: build-natives (linux-x64, ubuntu-latest)
  • GitHub Check: Java - SpotBugs + Checkstyle + PMD + Spotless
  • GitHub Check: CodeQL Analysis (java-kotlin)
  • GitHub Check: Outdated dependencies report
Additional context used

Code guidelines: 1

.github/CODERABBIT_REVIEW.md — configured
Path-based instructions: 3

Enforce meaningful assertions, deterministic concurrency, failure-path cleanup, and explicit native/stub requirements.

CodeRabbit configuration file

Files:

  • jpdfium/src/test/java/stirling/software/jpdfium/panama/NativeDownloaderTest.java
Apply the Java 25 and FFM rules from .github/CODERABBIT_REVIEW.md.

CodeRabbit configuration file

Files:

  • jpdfium/src/test/java/stirling/software/jpdfium/panama/NativeDownloaderTest.java
  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java
Source excerpt: These rules apply to maintained source.

CodeRabbit inference engine (.github/CODERABBIT_REVIEW.md)

Files:

  • jpdfium/src/test/java/stirling/software/jpdfium/panama/NativeDownloaderTest.java
  • jpdfium/src/main/java/stirling/software/jpdfium/panama/NativeDownloader.java
  • docs/native-loading.md
  • docs/installation.md
  • .github/workflows/mirror-central-to-r2.yml
  • .github/workflows/release.yml
zizmor (1.31.1)

.github/workflows/mirror-central-to-r2.yml

[warning] 76-76: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[warning] 3-27: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting

(concurrency-limits)

.github/workflows/release.yml

[warning] 1121-1121: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[warning] 1160-1160: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[warning] 1119-1119: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment

(undocumented-permissions)


[error] 1168-1168: runtime artifacts potentially vulnerable to a cache poisoning attack (cache-poisoning): omitting cache-disabled enables caching

(cache-poisoning)

Additional comments: 1

.github/workflows/release.yml: 1

1208-1208: Data Integrity & Integration

The inspection does not establish that the rebuilt archives differ or that their differences cause a verification failure. The proposed archive settings are already Gradle defaults. Independently generated signatures can differ, but that alone does not establish a defect.

Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
Comment thread docs/installation.md Resolved
@balazs-szucs
balazs-szucs added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 214c2ec Nov 20, 2026
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants