Replace Astropy logging with standard Python logging.#177
Open
Sudarshan-21 wants to merge 5 commits intoStingraySoftware:mainfrom
Open
Replace Astropy logging with standard Python logging.#177Sudarshan-21 wants to merge 5 commits intoStingraySoftware:mainfrom
Sudarshan-21 wants to merge 5 commits intoStingraySoftware:mainfrom
Conversation
Author
…ifice imports to use the central/global instance of logger
Author
kashish2210
reviewed
Apr 26, 2025
| import logging | ||
| import os | ||
| from contextlib import contextmanager | ||
|
|
Member
There was a problem hiding this comment.
You may include good UX like Stingray have you can visit this functions
And then change console_handler (something like this)
console_handler.setFormatter(ColoredFormatter())
Author
There was a problem hiding this comment.
Thank you for the suggestion!!
A colored log would be a great enhancement. I would look forward to achieving this, once the current PR gets approval from maintainers.
Member
|
Hey @Sudarshan-21 this PR looks good start to me:) @matteobachetti your review required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes issue #102
This PR aims to eliminate the usage of Astropy logging and implement logging using Python's standard logging library.
edit 26/04/2025
As of now, with the current changes, the logging is successfully being done using the standard Python logging module.
Current behaviour can be seen at: HENDRICS/pull/177#issuecomment-2831530914
I need to know the purpose of the commented codes like:
in the
hendrics/tests/test_a_complete_run.pyand similar files, in order to migrate to their new standard logger counterpart.I would like to hear the inputs and reviews about any missing modifications, or failure of the new logging method.
@matteobachetti @bsipocz @kashish2210 @ankitkhushwaha