Skip to content

Update delimiter fallback in CSV export function #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jenswittmann wants to merge 4 commits into
base: 3.x
Choose a base branch
from
Draft

Update delimiter fallback in CSV export function #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b75bef
Add export_csv_delimiter configuration key
jenswittmann Mar 2, 2026
90bfcff
Change default export delimiter value to empty
jenswittmann Mar 2, 2026
22893fa
Use configurable CSV delimiter for fputcsv
jenswittmann Mar 2, 2026
c3649a8
add delimiter systemsetting to modal
jenswittmann Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions _build/gpm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ systemSettings:
- key: max_chars_textfield
area: formit
value: 125
- key: export_csv_delimiter
area: formit
value: ;

chunks:
- name: fiDefaultEmailTpl
Expand Down
2 changes: 1 addition & 1 deletion assets/components/formit/js/mgr/widgets/forms.grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ FormIt.window.ExportForms = function(config) {
name : 'delimiter',
anchor : '100%',
allowBlank : false,
value : ';'
value : MODx.config['formit.export_csv_delimiter']
}, {
xtype : MODx.expandHelp ? 'label' : 'hidden',
html : _('formit.label_export_delimiter_desc'),
Expand Down
4 changes: 2 additions & 2 deletions core/components/formit/src/FormIt/Processors/Mgr/Forms/Export.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public function setFile()
$defaultColumns = array_map('strtolower', explode(',', $this->getProperty('columns')));

if ($columns) {
fputcsv($fopen, $columns, $this->getProperty('delimiter'));
fputcsv($fopen, $columns, $this->getProperty('delimiter', $this->modx->getOption('formit.export_csv_delimiter')));

foreach ($data as $row) {
$value = [];
Expand All @@ -231,7 +231,7 @@ public function setFile()
}
}

fputcsv($fopen, $value, $this->getProperty('delimiter'));
fputcsv($fopen, $value, $this->getProperty('delimiter', $this->modx->getOption('formit.export_csv_delimiter')));
}
}

Expand Down