feat: add explicit asset contract verification in create_escrow - #291
Merged
chizzy192 merged 3 commits intoJul 30, 2026
Merged
Conversation
|
@sudo-robi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Added error variants: InvalidPaymentToken, InvalidInvoiceToken, IdenticalTokens - Added verify_token_contract helper using try_invoke_contract on balance - create_escrow now validates: different tokens, valid payment token, valid invoice token - Added balance method to MockInvoiceToken for test support - Updated 10 tests to use real token contracts instead of Address::generate - Fixed pre-existing InvalidPayer/Paused duplicate discriminant (StellarState#15) - Fixed funder_opt.into_val compilation error in record_payment/refund - Added ensure_not_paused check to create_escrow - All 59 tests pass, clippy clean, fmt clean
Contributor
|
Hi @sudo-robi, please rebase your branch on dev to resolve merge conflicts in |
- test_initialize_not_authorized: update should_panic expected string to match actual HostError(Error(Auth, InvalidAction)) from require_auth() - test_create_escrow_requires_seller_auth: use mock_all_auths + real token contracts - test_update_platform_fee_requires_admin_auth: add mock_all_auths, assert success - test_set_paused_requires_admin_auth: add mock_all_auths, assert success - payment-distributor integration tests: replace env.auths() invocation checks with distributor state verification (env.invoke_contract sub-calls not recorded in auth framework) - payment-distributor test.rs: fix variable name compilation errors - Regenerated all test snapshot files to match fixed test behavior
sudo-robi
force-pushed
the
feature/invoice-escrow-token-verification
branch
from
July 30, 2026 15:40
205ed7b to
68aa62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #92
Summary
Adds explicit verification that payment_token and invoice_token are valid, distinct token contracts in the create_escrow function.
Changes