Draft
Fix admin-transfer test coverage and remove ineffective auth assertions#281
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix admin-transfer test coverage and remove ineffective auth assertions
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the review feedback on the new
transfer_admintests inpayment-distributor. The previous unauthorized-path test did not validate authorization behavior and included unused variables; the chain test comment/flow also did not reflect what was actually being asserted.transfer_adminunauthorized-path test correctedtest_transfer_admin_fails_if_unauthorizedto assert the contract’s authorization guard directly instead of relying onmock_all_auths()behavior.unauthorized_caller, intermediateresultusage that was not asserted).Admin-chain test assertion flow fixed
test_transfer_admin_chainto execute the second transfer step and assert state transition tonew_admin_2.