Fix transfer_admin tests to validate auth behavior and chained state transitions - #280
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on all comments in review thread
Fix Jul 28, 2026
transfer_admin tests to validate auth behavior and chained state transitions
chizzy192
marked this pull request as ready for review
July 29, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review-thread feedback on PR #273 by fixing the
transfer_admintest cases that were not asserting the intended behavior. The update is scoped to the commented tests only, with no contract logic changes.test_transfer_admin_fails_if_unauthorizednow validates auth failure correctlyenv.mock_all_auths()from this test (which previously bypassedrequire_auth()).mock_authssetup for:initializebyadmintransfer_adminattempted byunauthorized_callertest_transfer_admin_chainnow executes and verifies the second transferadmin -> new_admin_1new_admin_1 -> new_admin_2transfer_admincall before asserting final admin.Test imports updated for explicit auth mocking
MockAuth,MockAuthInvoke, andIntoValto support invocation-scoped auth setup.