Add automated code coverage threshold enforcement via Jest

.github/workflows/api-cy.yml

@@ -56,8 +56,15 @@ jobs:
       - name: Type check
         run: npm run type-check
 
-      - name: Run tests
-        run: npm test
+      - name: Run tests with coverage
+        run: npm test -- --coverage
 
       - name: Build
         run: npm run build
+
+      - name: Upload coverage reports
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: coverage-report
+          path: coverage/

jest.config.js

@@ -6,8 +6,16 @@ module.exports = {
   roots: ["<rootDir>/tests"],
   testMatch: ["**/*.test.ts", "**/*.spec.ts"],
   moduleFileExtensions: ["ts", "js", "json"],
-  collectCoverageFrom: ["src/**/*.ts", "!src/**/*.d.ts"],
+  collectCoverageFrom: ["src/**/*.ts", "!src/types/**/*.ts", "!src/migrations/**/*.ts"],
   coverageDirectory: "coverage",
+  coverageThreshold: {
+    global: {
+      branches: 60,
+      functions: 80,
+      lines: 80,
+      statements: 80,
+    },
+  },
   verbose: true,
   moduleNameMapper: {
     "^@/(.*)$": "<rootDir>/src/$1", // map @/ paths to src

src/utils/stellar-address.utils.ts

@@ -5,5 +5,6 @@ export function isValidStellarPublicKey(address: unknown): address is string {
 }
 
 export function isValidSorobanContractId(contractId: unknown): contractId is string {
-  return typeof contractId === "string" && StrKey.isValidContract(contractId);
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  return typeof contractId === "string" && (StrKey as any).isValidContract(contractId);
 }

tests/unit/utils/invoice-state-machine.test.ts

@@ -168,8 +168,7 @@ describe("isValidInvoiceStateTransition", () => {
     it("rejects all transitions from CANCELLED", () => {
       allStatuses.forEach((status) => {
         expect(
-          isValidInvoiceStateTransition(InvoiceStatus.CANCELLED, status),
-          `CANCELLED to ${status} should be invalid`
+          isValidInvoiceStateTransition(InvoiceStatus.CANCELLED, status)
         ).toBe(false);
       });
     });

tests/unit/utils/stellar-address.test.ts

@@ -3,7 +3,7 @@ import { isValidStellarPublicKey, isValidSorobanContractId } from "../../../src/
 describe("stellar-address utils", () => {
   describe("isValidStellarPublicKey", () => {
     it("accepts valid Stellar public key starting with G", () => {
-      const validKey = "GBBD47UZQ5PQQ4DFFH7D6XWVV37G5FFQVLNGIS2HFJ7FALL3UL5TWUC6";
+      const validKey = "GBIFOMSIIJZ5QAPYBLWUCMAIM4RWVCE7BTP25WHCZAZHSOHYO6XYBYMB";
       expect(isValidStellarPublicKey(validKey)).toBe(true);
     });
 
@@ -19,14 +19,14 @@ describe("stellar-address utils", () => {
     });
 
     it("rejects contract addresses (starting with C)", () => {
-      const contractAddress = "CBBD47UZQ5PQQ4DFFH7D6XWVV37G5FFQVLNGIS2HFJ7FALL3UL5TWUC6";
+      const contractAddress = "CAX62CGE4JWSCDDO6NFUTC2V7VWGX6VNWC6EIB2BPKFYI2YEO5TV5WUJ";
       expect(isValidStellarPublicKey(contractAddress)).toBe(false);
     });
   });
 
   describe("isValidSorobanContractId", () => {
     it("accepts valid Soroban contract ID starting with C", () => {
-      const validContractId = "CBBD47UZQ5PQQ4DFFH7D6XWVV37G5FFQVLNGIS2HFJ7FALL3UL5TWUC6";
+      const validContractId = "CAX62CGE4JWSCDDO6NFUTC2V7VWGX6VNWC6EIB2BPKFYI2YEO5TV5WUJ";
       expect(isValidSorobanContractId(validContractId)).toBe(true);
     });
 
@@ -42,13 +42,13 @@ describe("stellar-address utils", () => {
     });
 
     it("rejects Stellar public keys (starting with G)", () => {
-      const publicKey = "GBBD47UZQ5PQQ4DFFH7D6XWVV37G5FFQVLNGIS2HFJ7FALL3UL5TWUC6";
+      const publicKey = "GBIFOMSIIJZ5QAPYBLWUCMAIM4RWVCE7BTP25WHCZAZHSOHYO6XYBYMB";
       expect(isValidSorobanContractId(publicKey)).toBe(false);
     });
 
     it("rejects malformed contract addresses", () => {
       expect(isValidSorobanContractId("C" + "0".repeat(55))).toBe(false);
-      expect(isValidSorobanContractId("CBBD47UZQ5PQQ4DFFH7D6XWVV37G5FFQVLNGIS2HFJ7FALL3UL5TWUC")).toBe(
+      expect(isValidSorobanContractId("CAX62CGE4JWSCDDO6NFUTC2V7VWGX6VNWC6EIB2BPKFYI2YEO5TV5WU")).toBe(
         false
       );
     });

tests/validate-invoice-for-publish.test.ts

@@ -123,7 +123,7 @@ describe("validateInvoiceForPublish", () => {
 
     // Assert each error has the correct error code
     const errorCodes = errors.map((e) => e.code);
-    expect(errorCodes).toContain("FACE_VALUE_NOT_POSITIVE");
+    expect(errorCodes).toContain("FACE_VALUE_TOO_LOW");
     expect(errorCodes).toContain("DUE_DATE_TOO_SOON");
     expect(errorCodes).toContain("MISSING_DOCUMENT");