feat: invoice state machine, Soroban utilities, and invoice endpoints - #199
Merged
Chucks1093 merged 1 commit intoJul 29, 2026
Merged
Conversation
- Add isValidInvoiceStateTransition() utility for validating invoice state machine transitions (DRAFT -> PUBLISHED -> FUNDED -> SETTLED) - Add comprehensive unit tests for all 36 state transition permutations - Add isValidSorobanContractId() validator using StrKey.isValidContract() - Add unit tests for Soroban contract ID validation - Add getInvoiceTokenHolders() endpoint to query token holders and percentage shares - Add getInvoiceEscrowStatus() endpoint to query on-chain escrow contract status - Update invoice.service to accept dataSource for Investment queries - Add routes for new invoice endpoints Closes StellarState#164 StellarState#163 StellarState#161 StellarState#160
|
@EmmanuelOchaje Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements all four issues related to invoice management utilities and API endpoints:
Implementation Details
Issue #164 - Invoice State Machine
File:
src/utils/invoice-state.utils.tsisValidInvoiceStateTransition(currentStatus, targetStatus): booleanFile:
tests/unit/utils/invoice-state-machine.test.tsIssue #163 - Soroban Contract ID Validator
File:
src/utils/stellar-address.utils.tsisValidSorobanContractId(contractId: string): booleanStrKey.isValidContract()from stellar-sdk to validate 56-character C-address formatFile:
tests/unit/utils/stellar-address.test.tsIssue #161 - Invoice Token Holders Endpoint
File:
src/controllers/invoice.controller.tsgetInvoiceTokenHolders()File:
src/services/invoice.service.tsgetInvoiceTokenHolders(invoiceId: string)File:
src/routes/invoice.routes.tsGET /api/v1/invoices/:id/tokensIssue #160 - Invoice Escrow Status Endpoint
File:
src/controllers/invoice.controller.tsgetInvoiceEscrowStatus()File:
src/services/invoice.service.tsgetInvoiceEscrowStatus(invoiceId: string)File:
src/routes/invoice.routes.tsGET /api/v1/invoices/:id/escrowTest Coverage
Closes #164, Closes #163, Closes #161, Closes #160.