fix(api): return 415 for missing/incorrect content type - #211
Merged
Manuel1234477 merged 1 commit intoJul 29, 2026
Merged
Conversation
Closes StellarGateLabs#132 JsonBody previously mapped MissingJsonContentType to a generic 400, making wrong content-type requests indistinguishable from other body errors. Now returns 415 with code unsupported_media_type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonBody'sFromRequestimpl mappedJsonRejection::MissingJsonContentTypeto a generic 400, so clients sending the wrong Content-Type couldn't distinguish it from other body-validation errors. This now returns a 415 with a dedicatedunsupported_media_typecode.Closes #132
Validation performed
rustfmt --checkon the changed file (clean for the lines touched)cargo check/clippycurrently fail repo-wide due to a pre-existing unrelated syntax error insrc/api/mod.rs(rate_limit_middleware, unclosedlet limited = { ... }block) present onmainbefore this change — not touched here, out of scope for this issue.