feat(invoice): add split rounding auditor with largest-remainder corr… - #603
Merged
Kingsman-99 merged 2 commits intoJul 30, 2026
Merged
Conversation
…ection
- Add SplitLine, RoundingAdjustment, and AuditedSplitResult interfaces
to src/types.ts
- Implement auditSplitRounding() in src/invoice/rounding.ts:
- Computes per-recipient floor amounts from bigint total × float ratio
- Applies largest-remainder method to distribute stroop remainder
deterministically (highest fractional part wins, stable tie-break)
- Records every +/-1 stroop adjustment in AuditedSplitResult.adjustments
- Throws RoundingOverflowError when total adjustment exceeds
ceil(splits.length / 2) stroops
- Add src/invoice/calculator.ts with calculateSplitAmounts() and
computeAmounts() wrappers integrating the auditor
- Add 20 tests in test/roundingAuditor.test.ts covering:
- Exact division (no correction needed)
- 3-way uneven split requiring +1 stroop correction
- 1-stroop invoice split across 3 recipients
- Largest-remainder ordering is deterministic
- RoundingOverflowError when ratios deviate too far from 1.0
- Sum invariant across a range of totals and ratios
- calculator.ts integration
Closes Stellar-split#590
|
@gracepeterfejokwu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ection
Closes #590