Implement LRU cache (#150) #111
Open
+208
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: update dependencies and implement LRU cache - bump spin to 0.10.0 and chrono to 0.4.43 - modify Makefile to disable VSOCK - add LRU cache implementation in core/src/lrucache.rs - refactor memory management to use new LRU cache methods * feat: enable VSOCK support in QEMU options * feat: remove uluru dependency from Cargo files * feat: reorganize lrucache module import in lib.rs and mm.rs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the external uluru dependency with a custom LRU cache implementation to address licensing concerns (implied by the PR title "fix license"). The implementation provides equivalent functionality for caching ELF file entries in the memory management module.
Changes:
- Implemented a custom
LruCachewith doubly-linked list structure using array indices - Migrated from
uluru::LRUCacheto the newLruCachein the memory management module - Removed the
ulurudependency from Cargo files and updatedchronoto version 0.4.43
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/lrucache.rs | New custom LRU cache implementation with fixed-size array storage and intrusive linked list |
| core/src/mm.rs | Updated to use new LruCache API (access, put, peek_mru, items, flush methods) |
| core/src/lib.rs | Added lrucache module to the module tree |
| core/Cargo.toml | Removed uluru dependency |
| Cargo.lock | Removed uluru package and updated chrono to 0.4.43 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…he more clearly and ensure that CAP is suitable for u16 index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: remove uluru dependency from Cargo files
feat: reorganize lrucache module import in lib.rs and mm.rs
Description
Implementation
Additional Context