Repository navigation
Conversation
New parameters without documentationThis PR introduces 5 parameter(s) not yet documented. Please add entries before or shortly after merge. BE Configuration — 5 undocumented
Auto-generated by |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
becbe23 to
d4e48aa
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: becbe235ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddacb1c446
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c323599e73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb7797e35d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ece20340c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Re-run the workflow |
|
@codex review |
|
Re-run the workflow |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b23a98d8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@kevincai Hey Kevin, looks like the CI runners are having trouble reaching GitHub. |
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
7765590 to
769b184
Compare
🌎 Translation Required?✅ All translation files are up to date.
|
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
Merge current main without rewriting the PR history. Point the English, Chinese and Japanese configuration templates to existing FE/BE reference pages and use local system-variable links. Validate with Lychee 0.23.0: 7651 local links passed; 139 targeted FE tests and FE build passed. Schema compatibility, BE module boundaries and handbook checks passed. Documentation-only fix; existing ADBC profiles, logs and metrics are preserved. Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
|
I tested locally with postgres. Mostly worked fine except when driver returns opaque extension types like Also I think eventually it would be better to handle pushdown sql generation for adbc seperately when apache/arrow#49796 is merged and drivers self-declare relevant info codes. |
PostgreSQL driver does that, the decimal/numeric problem. Starrocks arrow converter doesnt have a layer for opaque extension, that is why I try to push "flightsql-only" narrative for now, otherwise supporting every ADBC driver would take time and investment on arrow side of starrocks. ADBC feature can make lots of improvements on how Starrocks interract with modern engines, in agentic era, including pushdown, as you said. |
Signed-off-by: Metehan Yildirim <metegenez@gmail.com>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 450 / 493 (91.28%) file detail
|
[BE Incremental Coverage Report]✅ pass : 307 / 320 (95.94%) file detail
|
Why I'm doing
Apache Arrow ADBC is evolving quickly, with a growing driver ecosystem. I expect broader adoption across OLAP engines in the near term. Its Arrow batch interface reduces row-by-row conversion overhead and can make bulk analytical reads substantially faster than JDBC's row-oriented API (Java performance comparison).
This is the first step toward broader ADBC support: a small, read-only integration through the ADBC Driver Manager, with Flight SQL as the first validated source. If we agree on this direction, I plan to follow up with broader driver coverage, source-specific metadata support and additional capabilities.
For background, I previously explored ADBC in #70297, where the Go/CGO dependency prompted the Driver Manager suggestion. I waited for ADBC 24 to complete the FE integration using upstream JNI metadata APIs. This connector builds without Go/CGO and loads source drivers at runtime.
What I'm doing
Fixes #69868
Add a read-only
adbcexternal catalog. ADBCdb_schemamaps to a StarRocks database. Scans support projection, predicate andLIMITpushdown through one stream.adbc_driver_flightsql. Users install their chosen compatible driver on each FE and BE/CN.flowchart LR FE["FE: metadata + JNI + Driver Manager"] -->|scan plan| BE["BE/CN: scan + Driver Manager"] FE --> FD["User-installed driver on FE"] BE --> BD["User-installed driver on BE/CN"] FD --> Source["Data source: Flight SQL verified"] BD -->|"SQL / Arrow batches"| SourceUses ADBC Java 0.24.0 with Arrow Java 18.0.0. Writes and distributed partitions are outside this version.
Diff size: 5,550 added lines: 2,426 implementation/build, 2,529 tests, and 595 Markdown docs/guides. There are 18 deleted lines.
Catalog creation
CREATE EXTERNAL CATALOG flight_sql PROPERTIES ( "type" = "adbc", "driver" = "adbc_driver_flightsql", "uri" = "grpc+tls://flight.example.com:31337", "username" = "<user>", "password" = "<password>" ); SHOW DATABASES FROM flight_sql; SELECT n_nationkey, n_name FROM flight_sql.main.nation WHERE n_nationkey = 24 LIMIT 1;See the ADBC catalog guide for driver installation and FE configuration. EN/ZH/JA docs are included. The AI-generated Japanese translation needs native-speaker review.
Validation
Live E2E was run manually; it is not yet in the SQL integration suite. Coverage: metadata, pushdown, quoted columns/literals, scalar values, 10,000 rows across chunks, DDL redaction and execution profiles.
Test environment
I verified the builds on my ARM64 Docker host with the optional benchmark connector and StarCache disabled. SQLFlite's embedded-quote table-name limitation has unit and direct JNI coverage.
Observability: ADBC uses
catalog_type="adbc"for FE query metrics and BE scan metrics. Existing scan profiles, driver/metadata error context and credential masking are preserved. ADBC scans render in optimizer plans and query history. MV freshness checks retain the existing refresh logs, timers and query-cache counters.What type of PR is this
Does this PR entail a change in behavior?
If yes, please specify the type of change:
adbccatalog, metadata and scan supportChecklist
Bugfix cherry-pick branch check
Not applicable: new feature, no backport requested.