Fix LDAP filter injection#1
Open
Montana wants to merge 1 commit intoStanford:masterfrom
Open
Conversation
The most critical fix is preventing LDAP filter injection. The original code built filter strings with bare f-strings like f"uid={sunetid}", which means a malicious input like *)(|(cn=* could break out of the filter and return arbitrary results. I added import ldap.filter at the top and created a private _build_uid_filter method that runs the sunetid through ldap.filter.escape_filter_chars() before interpolating it, and wraps the result in proper parentheses as (uid=...).
All three convenience methods, sunetid_account_info, sunetid_people_info, and sunetid_info, now use this helper instead of constructing the filter inline.
Montana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Stanford University,
The most critical fix is preventing LDAP filter injection. The original code built filter strings with bare f-strings like
f"uid={sunetid}", which means a malicious input like*)(|(cn=*could break out of the filter and return arbitrary results.I added
import ldap.filterat the top and created a private_build_uid_filtermethod that runs the sunetid throughldap.filter.escape_filter_chars()before interpolating it, and wraps the result in proper parentheses as(uid=...).All three convenience methods —
sunetid_account_info,sunetid_people_info, andsunetid_info— now use this helper instead of constructing the filter inline.Sincerely,
Michael