You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Creative inventories now retain catalog entries and support improved search, categories, item placement, and toolbar behavior.
Player and workbench crafting previews show recipe choices and output quantities; Survival bulk crafting is supported.
Merchant screens display trade offers and handle selections, item placement, and returned inputs.
Native presentations support forms, containers, conversations, titles, action bars, and persistent HUD decorations, with fallback displays where needed.
Bundle transfers support validated insertion and extraction, with desktop extraction behavior for native inventories.
Bug Fixes
Inventory and trade updates better handle rejected actions, synchronization, and changing screen state.
Resolve retained storage policy maps through the native descriptor matcher and keep lazy name resolution on the selected definition. Apply available filters and nesting admission to ordinary Java bundle insertion before prediction, with the existing fallback for unverified expression contexts.
Replay all 107 core patches. Verify 2,106 executed core tests, both Checkstyle tasks and the first-patch PR projection. Native physical-slot request execution and installed controller validation remain unfinished.
No actionable comments were generated in the recent review.
Walkthrough
The patch set extends retained Bedrock creative and recipe integration and adds native storage-policy checks and request-tracked bundle transfers. The authored UI patch adds default extraction from the last qualifying physical bundle slot. Related patch documentation and metadata are updated.
Changes: Retained inventory and bundle behavior
Layer / File(s)
Summary
Creative catalog and recipe integration patches/viabedrock/deferred/0012-retain-bedrock-creative-catalog-entries.patch
ItemRewriter now exposes a CreativeCatalog and adds recipe-preview construction and a PlayerRecipeContext overload for recipe availability.
Storage policy binding and insertion validation patches/viabedrock/deferred/0012-retain-bedrock-creative-catalog-entries.patch
Item definitions cache native storage-policy bindings. Bundle insertion applies available native filters and nesting rules. Tests and patch documentation cover policy matching and insertion outcomes.
Physical-slot bundle transfers and extraction patches/viabedrock/deferred/0012-retain-bedrock-creative-catalog-entries.patch, patches/viabedrock/deferred/0012-retain-bedrock-creative-catalog-entries.pr.md, patches/viabedrock/upstreamable/0095-integrate-authored-native-ui-presentation.patch, patches/viabedrock/upstreamable/0095-integrate-authored-native-ui-presentation.pr.md, patches/viabedrock/deferred/0014-translate-bedrock-merchant-inventories-in-core.patch
Bundle action sessions submit ordered requests and reconcile predictions against responses. The authored UI patch adds default extraction from the last qualifying physical slot. Patch notes, counts, and identifiers are updated; the merchant patch change updates identifiers and a diff header.
sequenceDiagram
participant Container
participant NativeBundleActionSession
participant InventoryRequestTracker
participant Server
Container->>NativeBundleActionSession: Request an insertion or extraction
NativeBundleActionSession->>InventoryRequestTracker: Submit ordered requests with chained IDs
InventoryRequestTracker->>Server: Send transfer requests
Server-->>InventoryRequestTracker: Return accepted or rejected responses
InventoryRequestTracker-->>NativeBundleActionSession: Provide response results
NativeBundleActionSession->>NativeBundleActionSession: Reconcile matching predictions
Loading
Possibly related PRs
StackAnvil/patches#45: Binds native storage policies and bundle transfer behavior to definition-owned items.
StackAnvil/patches#44: Adds native physical-slot bundle transfer planning used by the bundle behavior in this change.
StackAnvil/patches#16: Updates the same retained creative-catalog patch with catalog identity and retained recipe models.
Merge Risk: Minimal · up to dfb19
The change adds bundle storage-filter checks and native bundle transfers to the patch stack. No concrete runtime or replay defect remains, so it is mergeable. Splitting the bundle work out of the creative-catalog patch would be a reasonable later cleanup.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "chore: continue compatibility maintenance" is partially related to the changeset. The change set is a large compatibility patch series for Bedrock inventory, creative catalog, bundle, merch…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "chore: continue compatibility maintenance" is partially related to the changeset. The change set is a large compatibility patch series for Bedrock inventory, creative catalog, bundle, merchant, and native UI behavior, and the PR objectives describe it as continued compatibility maintenance after 0.4.25. The title names the general purpose but not the main functional change, and it is broad. It is not unrelated, and it is not vague enough to be inconclusive because it does describe the nature of the work.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Add an opening-bound backend that resolves current storage owners, runs the native physical-slot planner and submits separately predicted transfer requests through the ordered request tracker. Chain changed-slot request IDs and preserve preparation requests when incoming-item admission fails.
Keep unavailable insertion filters out of Java fallback admission. Preserve newer authoritative updates, replacement dynamic owners and replacement crafting grids during rollback. The backend is not yet connected to add-on controller input.
Verify eleven new boundary cases, all 107 core patches, 2,117 executed core tests, both Checkstyle tasks and the first-patch PR projection. Native wire grouping and installed direct/proxy controls remain unfinished.
Keep desktop default extraction separate from selected-cell extraction. Scan backward for the last physical entry, emit one Take without compaction and retain the transfer result. Preserve zero-count definition identity without treating userdata-only empty slots as occupied.
Add planner and request-boundary regressions for partial merging, rejection, empty vectors, authoritative acceptance and full-cursor no-op. Record 328 version-matched native instruction controls distinguishing desktop state1 predicates from the touch state45 path.
Verify all 107 core patches, 2,122 executed core tests, both Checkstyle tasks and the first-patch PR projection. Controller transport and installed direct/proxy comparisons remain unfinished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue compatibility maintenance after 0.4.25.
Created with GPT-6.1 Sol in T3 Code.
Summary by CodeRabbit