Skip to content

chore: continue compatibility maintenance - #43

Merged
AlexProgrammerDE merged 2 commits into
mainfrom
t3/maintenance-session-8
Nov 4, 2026
Merged

AlexProgrammerDE merged 2 commits into
mainfrom
t3/maintenance-session-8

Conversation

@AlexProgrammerDE

@AlexProgrammerDE AlexProgrammerDE commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Continue compatibility maintenance after 0.4.22.

Created with GPT-6.1 Sol in T3 Code.

Summary by CodeRabbit

  • New Features
    • Added native presentations for containers, cooking screens, and player inventory, with support for recipe browsing, search, progress, and preferences.
    • Added native forms, NPC dialogue, HUD, and hurt-state displays.
    • Added support for native UI textures and bitmap or Unicode fonts.
    • Added a setting to control native inventory-screen presentation; it is enabled by default.
  • Improvements
    • Native screens retain standard inventory interactions, and unsupported or outdated presentations fall back to the usual screen.
    • Improved item previews, filtering, tooltips, and display consistency.

Populate collection-details metadata without requiring a binding name, then export the final control-local property bag after binding updates. Read inventory hover sources from that bag instead of render-slot annotations.

Fold the change into the shared UI and container owners. Original Bedrock 1.26.60.5 controls verify binding type, ancestor collection lookup, prefixed maps and retained typed source reads. Add boundary regressions for program transport and routed slot events.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The patch updates collection-detail binding export in shared JSON UI programs and changes native container input to read collection names and indices from evaluated control property bags. It adds regression coverage and validation notes for both paths.

Changes: Collection binding and event data

Layer / File(s) Summary
Initialize and export collection bindings
patches/viabedrock/upstreamable/0095-share-native-ui-programs-and-resources.patch, patches/viabedrock/upstreamable/0095-share-native-ui-programs-and-resources.pr.md
JsonUiProgram.bind initializes named and unnamed collection_details values, applies prefixes, and exports resolved bound values in each control’s property_bag. Tests cover local bags, binding updates, and export/import resolution. The validation notes describe the tested behavior and remaining validation limits.
Resolve native event collection data
patches/viafabricplus-bedrock/upstreamable/0029-present-authored-native-containers.patch, patches/viafabricplus-bedrock/upstreamable/0029-present-authored-native-containers.pr.md
NativeContainerInput.Event reads collection names and indices from the event’s property_bag. Player and cooking event paths use the resolved collection data. Tests cover bag updates, invalid values, integer bounds, and narrowing; the cooking fixture adds a collection_details binding.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Possibly related PRs

  • StackAnvil/patches#16: It contains the same shared UI program/resource and authored-container patches, plus recipe and inventory APIs used by the cooking and container scenes.
  • StackAnvil/patches#26: It contains the same UI program/resource and authored-presentation patch families, with presentation adapters that consume their scenes and resource definitions.
  • StackAnvil/patches#29: It changes the same shared UI program and authored-container patches, and its shared scene renderer consumes those programs and resources.
Merge Risk: Minimal · up to 97028

No actionable merge-blocking risk was established for these changes.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "chore: continue compatibility maintenance" is generic. It does not name the main change, which adds shared native UI programs and resources (ViaBedrock) and authored native container and co… Rewrite the title to name the primary change. For example: "feat: add native UI programs and authored native container screens". Keep it to one short sentence that a teammate can scan.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Full details: Title check

Explanation

The title "chore: continue compatibility maintenance" is generic. It does not name the main change, which adds shared native UI programs and resources (ViaBedrock) and authored native container and cooking screens (ViaFabricPlus-Bedrock). The title is a vague, broad phrase that could describe almost any compatibility work, so a teammate scanning history cannot tell the primary change.

Resolution

Rewrite the title to name the primary change. For example: "feat: add native UI programs and authored native container screens". Keep it to one short sentence that a teammate can scan.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 85ac2bd and 970287f.

Files selected for processing: 4
  • patches/viabedrock/upstreamable/0095-share-native-ui-programs-and-resources.patch
  • patches/viabedrock/upstreamable/0095-share-native-ui-programs-and-resources.pr.md
  • patches/viafabricplus-bedrock/upstreamable/0029-present-authored-native-containers.patch
  • patches/viafabricplus-bedrock/upstreamable/0029-present-authored-native-containers.pr.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@AlexProgrammerDE
AlexProgrammerDE merged commit ee03456 into main Nov 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant