Skip to content

Conversation

@Potatomonsta
Copy link
Contributor

@Potatomonsta Potatomonsta commented Jan 7, 2026

Description

  • Changed the action type for closing the modal bottom sheet from "pop" to "navigate" with a "pop" navigation style in the StacModalBottomSheetAction class.
  • Enhanced the bottom sheet example JSON to include a structured widget definition, featuring a title, close button, and descriptive text, improving the demonstration of modal bottom sheet usage.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

Summary by CodeRabbit

  • Documentation
    • Updated modal bottom sheet examples to demonstrate navigation-based closing mechanism
    • Refactored gallery example to use inline widget structure for improved example clarity

✏️ Tip: You can customize this high-level summary in your review settings.

- Changed the action type for closing the modal bottom sheet from "pop" to "navigate" with a "pop" navigation style in the `StacModalBottomSheetAction` class.
- Enhanced the bottom sheet example JSON to include a structured widget definition, featuring a title, close button, and descriptive text, improving the demonstration of modal bottom sheet usage.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

Updated documentation and example files to reflect navigation-based modal bottom sheet closure. The modal bottom sheet now closes using actionType: "navigate" with navigationStyle: "pop" instead of actionType: "pop". Example JSON replaced external asset references with inline widget tree specifications.

Changes

Cohort / File(s) Summary
Documentation
docs/actions/modal_bottom_sheet.mdx
Updated onPressed action from actionType: "pop" to actionType: "navigate" with navigationStyle: "pop" to reflect new navigation closing pattern
Example
examples/stac_gallery/assets/json/bottom_sheet_example.json
Replaced assetPath-based content loading with inline widget tree; added self-contained UI structure including container, column, header row with "Modal Bottom Sheet" text, close icon button, and descriptive text. Close button now uses navigate action with navigationStyle: "pop"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A modal takes its final bow,
No popping acts—we navigate now!
With widgets inline, so snug and neat,
Our bottom sheets make navigation sweet!
No assets loaded from afar,
Just clean JSON—our code's a star!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updating the modal bottom sheet action type and example JSON file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
examples/stac_gallery/assets/json/bottom_sheet_example.json (1)

38-38: Consider: Fixed height may not accommodate varying content.

The container has a fixed height of 200, which works for this simple example but may not be suitable for all use cases. For production implementations, consider using dynamic sizing or making the height configurable based on content requirements.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e209f56 and 2724c31.

📒 Files selected for processing (2)
  • docs/actions/modal_bottom_sheet.mdx
  • examples/stac_gallery/assets/json/bottom_sheet_example.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: analyze
🔇 Additional comments (3)
examples/stac_gallery/assets/json/bottom_sheet_example.json (2)

36-86: Good improvement: Inline widget definition provides a clearer, self-contained example.

The replacement of the assetPath reference with an inline widget definition significantly improves the example's clarity and educational value. The widget structure demonstrates a typical modal bottom sheet pattern with a header (title + close button) and descriptive content.


67-70: Consistent with documentation: Using navigate action to close the modal bottom sheet.

The close button correctly uses actionType: "navigate" with navigationStyle: "pop", which is consistent with the updated documentation pattern. This demonstrates the recommended approach for dismissing modal bottom sheets.

docs/actions/modal_bottom_sheet.mdx (1)

56-59: Pattern verified—navigate with pop style is the standard approach for closing modal bottom sheets in Stac applications.

The change to actionType: "navigate" with navigationStyle: "pop" is consistent with the established pattern used throughout the codebase for closing modals, dialogs, and bottom sheets.

@divyanshub024 divyanshub024 merged commit e8d17e9 into dev Jan 9, 2026
5 checks passed
@divyanshub024 divyanshub024 deleted the mn/modal-sheet-example-fix branch January 9, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants