fix(Address): make address_2 writable in setMainFields() - #10
Open
Pichinov-Jose wants to merge 1 commit into
Open
fix(Address): make address_2 writable in setMainFields()#10Pichinov-Jose wants to merge 1 commit into
Pichinov-Jose wants to merge 1 commit into
Conversation
The `address_2` field is declared in buildMainFields() and readable in
getMainFields(), but was missing from the setMainFields() write switch.
Any inbound write containing `address_2` fell through to `default: return;`
without being consumed, so IntelParserTrait raised ErrLocalWrongField
("Field \"address_2\" do not Exists") and the entire address write failed.
Add the missing `case 'address_2':` alongside `address_1` so the second
address line is persisted like the other postal fields.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the
Addressobject, the second address line (address_2) is declared inbuildMainFields()and readable ingetMainFields(), but it is missing from thesetMainFields()write switch.Any inbound write that includes
address_2therefore falls through todefault: return;and the field is never consumed (unset($this->in[...])is not reached).IntelParserTraitthen raisesErrLocalWrongField:and the entire address write is rejected (
Last Change not exported).setMainFields()is the only setter for theAddressobject, so no other trait recovers the field. This affectsbilling-type addresses (logistic types intentionally skip writing).Fix
Add the missing
case 'address_2':alongsidecase 'address_1':insetMainFields(), so the second address line is persisted viasetUserMeta()like the other postal fields.Notes
schema.org/PostalAddress/postOfficeBoxNumber) is unchanged — only the write path was missing.masterand every 2.0.x tag (reproduced with v2.0.10 syncing customer addresses from another Splash connector).🤖 Generated with Claude Code