I discovered experimentally that my GitHub instance was causing my CLI app to hang. All of my code would complete executing and then the terminal would hang for nearly 20 seconds for no apparent reason.
Eventually I tried passing my own Client into GitHub and then manually closing the Client after loading info from GitHub. This immediately fixed the hanging issue.
By default, the Client should be closed within GitHub. If desired, perhaps you could add an option to use a long-lived connection, but in the absence of passing additional configuration, the default behavior should be to close the connection after every call. Otherwise developers will end up very confused like I was.
I discovered experimentally that my
GitHubinstance was causing my CLI app to hang. All of my code would complete executing and then the terminal would hang for nearly 20 seconds for no apparent reason.Eventually I tried passing my own
ClientintoGitHuband then manually closing theClientafter loading info from GitHub. This immediately fixed the hanging issue.By default, the
Clientshould be closed withinGitHub. If desired, perhaps you could add an option to use a long-lived connection, but in the absence of passing additional configuration, the default behavior should be to close the connection after every call. Otherwise developers will end up very confused like I was.