Skip to content

Manacher#5

Merged
Spill-Tea merged 10 commits into
mainfrom
manacher
Jul 12, 2025
Merged

Manacher#5
Spill-Tea merged 10 commits into
mainfrom
manacher

Conversation

@Spill-Tea

Copy link
Copy Markdown
Owner
  1. Implement a primitive numeric array in C++
  2. Clean up, improve and standardize _oligos module API.
  3. Implement the manacher algorithm

Spill-Tea added 5 commits July 8, 2025 17:39
…s have equivalents to act on str, StringView* and char*.

Inline several functions, improve or update documentation, and include a cython header (pxd) file for _oligos module. Pass pointer to translation tables in relevant complement functions for better efficiency.
@Spill-Tea

Spill-Tea commented Jul 9, 2025

Copy link
Copy Markdown
Owner Author

Pylint appears to be struggling with import errors related to cython modules. I do not observe this limitation (error) locally, only on remote testing. Reviewing previous PRs, this appears to have always been an error. However, with the inclusion of a second imported cython file in the PR, it is finally triggering a Failed response (below 9.0 threshold).

I believe it might be an issue to evaluating the src folder, but the build will be installed within a tox environment site packages. Perhaps, including the prefer-stubs argument in pylint configuration will overcome this?

I would prefer not to globally disable or ignore these errors, but this is also a problem that could be easily captured elsewhere. If we couldn't actually import a module, unit testing would fail spectacularly.

@Spill-Tea Spill-Tea merged commit c105512 into main Jul 12, 2025
5 checks passed
@Spill-Tea Spill-Tea deleted the manacher branch July 12, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant