Skip to content

Fix/readme conflict#41

Merged
Spiev merged 2 commits intomainfrom
fix/readme-conflict
Feb 3, 2026
Merged

Fix/readme conflict#41
Spiev merged 2 commits intomainfrom
fix/readme-conflict

Conversation

@Spiev
Copy link
Owner

@Spiev Spiev commented Feb 3, 2026

No description provided.

Stefan added 2 commits January 27, 2026 21:38
- Add migration guide: homeassistant/matter-migration.md
- Document migration from t0bst4r/home-assistant-matter-hub to Luligu/matterbridge
- Add EOL warning to README.md for Matter Hub service
- Upstream project end-of-maintenance since January 2026
Copilot AI review requested due to automatic review settings February 3, 2026 13:08
@Spiev Spiev merged commit 72cc0de into main Feb 3, 2026
8 checks passed
@Spiev Spiev deleted the fix/readme-conflict branch February 3, 2026 13:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR titled "Fix/readme conflict" deletes the entire Matter migration guide document (homeassistant/matter-migration.md), removing 274 lines of documentation that detailed the migration process from home-assistant-matter-hub to Matterbridge.

Changes:

  • Complete removal of the Matter migration guide documentation file
Comments suppressed due to low confidence (3)

homeassistant/matter-migration.md:1

  • This deletion creates a broken link in README.md. Line 24 of README.md references this file: [Migration to Matterbridge planned](./homeassistant/matter-migration.md). If this file is being deleted, the README.md should be updated in the same PR to either remove the reference or update it to point to the correct location.
    homeassistant/matter-migration.md:1
  • The complete deletion of this migration guide appears to be inconsistent with the current state of the codebase. The docker-compose.yml file (homeassistant/docker-compose.yml:26-35) still contains the matter-hub service configuration, suggesting the migration to Matterbridge has not been completed. If this PR is resolving a merge conflict, consider whether the file should be kept (accepting one side of the conflict) rather than deleted entirely, or if the migration has been completed, ensure all related configurations are updated accordingly.
    homeassistant/matter-migration.md:1
  • In the previous version of this documentation, the Docker Compose example used the third-party image luligu/matterbridge:latest, which pulls code from an external registry using a mutable latest tag. If the upstream image or registry is compromised, any redeploy or image pull could run attacker-controlled code in a container with access to your Home Assistant environment and secrets. This PR removes that guidance; when reintroducing deployment docs, pin images to specific, trusted versions or immutable digests instead of latest to reduce supply chain risk.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant