Skip to content

Spin gen enums#316

Merged
Christian-B merged 11 commits into
masterfrom
SPIN_GEN
Jun 12, 2026
Merged

Spin gen enums#316
Christian-B merged 11 commits into
masterfrom
SPIN_GEN

Conversation

@Christian-B

@Christian-B Christian-B commented Jun 8, 2026

Copy link
Copy Markdown
Member

Based on changes made in
https://gitlab.com/spinnaker2/SpiNNMachine2/-/blob/main/spinn_machine/version/version_factory.py

Create SPIN1_GEN and SPIN2_GEN enums to clearler show where the versions come from.

Changes to how SpiNNcloud did it.

  1. Classes SPIN1_GEN and SPIN2_GEN moved to their own py files
  2. Standalone constants THREE, FIVE, SPIN2_1CHIP, SPIN2_48CHIP completely removed
  3. when used in set_config wrapped in a str function for typing
  • note: it needs to be str(Spin2Gen.SPIN2_1CHIP.value) and not just str(Spin2Gen.SPIN2_1CHIP) for python 3.10

Must be done at the same time as SpiNNakerManchester/PACMAN#635 (or an alternative)

@Christian-B Christian-B requested a review from rowleya June 8, 2026 06:19
@Christian-B Christian-B changed the title Spin gen Spin gen enums Jun 8, 2026
@rowleya

rowleya commented Jun 8, 2026

Copy link
Copy Markdown
Member

Apologies, I approved this thinking it was part of the parameterized, but I think this one is in conflict, so probably should be closed instead.

@Christian-B Christian-B merged commit 596a971 into master Jun 12, 2026
11 checks passed
@Christian-B Christian-B deleted the SPIN_GEN branch June 12, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants