Skip to content

use parameterized to test ALL_BOARD_TYPES#313

Merged
Christian-B merged 16 commits into
masterfrom
parameterized
Jun 9, 2026
Merged

use parameterized to test ALL_BOARD_TYPES#313
Christian-B merged 16 commits into
masterfrom
parameterized

Conversation

@Christian-B

@Christian-B Christian-B commented Jun 1, 2026

Copy link
Copy Markdown
Member

Fixes #310

Using https://github.com/wolever/parameterized

Most changes are just using parameterized
Others are:

  • Remove Version string
  • Raise an error if config "versions" is used
  • Remove some tests that just check mock versions worked.
  • setup.cfg to test install parameterized
  • pyproject.toml to mypy skip parameterized

note; @pytest.mark.parametrize
as used in https://github.com/SpiNNakerManchester/spalloc/blob/67f72348045fd244cf7e99554ccea02da03b56ca/tests/test_term.py#L21

Does not appear to work with unittest

Advanatge:
Cleaner than and for loop and subtest

Disadvantage:
Does not allow running just this test method.

@Christian-B Christian-B marked this pull request as draft June 1, 2026 05:39
@Christian-B Christian-B merged commit e8bad6e into master Jun 9, 2026
25 checks passed
@Christian-B Christian-B deleted the parameterized branch June 9, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure all Machine versions tested for any python version

2 participants