Repository navigation
Bump GitHub Actions to Node 24 releases - #7
Merged
SpectrumFRC3847 merged 1 commit intoOct 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workflow does not preserve .nojekyll as described.
Review effort: Lite
Findings: 1
What changed in this PR
Updates the GitHub Pages workflow to Node 24-compatible GitHub Actions releases.
Changes:
- Upgrades checkout, Pages configuration, artifact upload, and deployment actions.
- The required hidden-file preservation input is missing, so
.nojekyllwill be excluded.
| File | Summary |
|---|---|
.github/workflows/deploy-pages.yml |
Updates Pages deployment action versions; add include-hidden-files: true or revise the .nojekyll intent. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Project516
force-pushed
the
project516/actions-node24
branch
3 times, most recently
from
October 1, 2026 20:08
1524c9f to
cb4ec95
Compare
Project516
force-pushed
the
project516/actions-node24
branch
from
October 12, 2026 22:40
cb4ec95 to
82cf738
Compare
Member
Author
|
@allengregoryiv ready for a review when you have a moment. Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this changes
actions/checkoutv4 to v7, indeploy-pages.yml,upstream-watch.ymland main's newlint.yml.actions/configure-pagesv5 to v6.actions/upload-pages-artifactv3 to v5.actions/deploy-pagesv4 to v5.include-hidden-files: trueto the upload step.GitHub is deprecating Node 20 on hosted runners. Each of these majors runs on Node 24 (
runs.usingisnode24for checkout, configure-pages and deploy-pages).upload-pages-artifactv5 is a composite action. It callsactions/upload-artifactv7.0.0, which is alsonode24.Release notes read for breaking changes:
pull_request_targetandworkflow_run. None of the three uses those triggers:deploy-pages.ymlruns onpushandworkflow_dispatch,upstream-watch.ymlonscheduleandworkflow_dispatch,lint.ymlonpush,pull_requestandworkflow_dispatch.pages: write,id-token: writepermissions are unchanged.training/.nojekyllis a dotfile, so v5 would have dropped it. The new input keeps the artifact contents the same as before.Rebased onto
mainatab6e086on 2026-10-12. No conflicts. Main addedlint.ymlwithactions/checkout@v4, so it is bumped here too. Everyuses:line in.github/workflows/is now on a Node 24 major.Checks
runs.usingvalue at each tag with the GitHub API, and that the major tags exist (checkout's latest release is v7.0.1).lint.ymlruns on this PR, so its checkout bump is exercised by this PR's own checks.deploy-pages.ymlandupstream-watch.ymlonly run frommain, so they are validated after merge.Noticed, not fixed
.nojekyllhas no effect for an Actions-based Pages deployment, so theinclude-hidden-filesline could be dropped along with the file. I left both in place to keep this change minimal.