Skip to content

Bump GitHub Actions to Node 24 releases - #7

Merged
SpectrumFRC3847 merged 1 commit into
Spectrum3847:mainfrom
Project516:project516/actions-node24
Oct 15, 2026
Merged

SpectrumFRC3847 merged 1 commit into
Spectrum3847:mainfrom
Project516:project516/actions-node24

Conversation

@Project516

@Project516 Project516 commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

What this changes

  • actions/checkout v4 to v7, in deploy-pages.yml, upstream-watch.yml and main's new lint.yml.
  • actions/configure-pages v5 to v6.
  • actions/upload-pages-artifact v3 to v5.
  • actions/deploy-pages v4 to v5.
  • Adds include-hidden-files: true to the upload step.

GitHub is deprecating Node 20 on hosted runners. Each of these majors runs on Node 24 (runs.using is node24 for checkout, configure-pages and deploy-pages). upload-pages-artifact v5 is a composite action. It calls actions/upload-artifact v7.0.0, which is also node24.

Release notes read for breaking changes:

  • checkout v5 requires runner 2.327.1 or newer, which hosted runners already meet. v7 blocks fork PR checkouts for pull_request_target and workflow_run. None of the three uses those triggers: deploy-pages.yml runs on push and workflow_dispatch, upstream-watch.yml on schedule and workflow_dispatch, lint.yml on push, pull_request and workflow_dispatch.
  • configure-pages v6 is only the Node 24 upgrade. The v5 break was about Next.js, which this site does not use.
  • deploy-pages v5 is the Node 24 upgrade plus polling backoff. The pages: write, id-token: write permissions are unchanged.
  • upload-pages-artifact v4 stopped including dotfiles. training/.nojekyll is a dotfile, so v5 would have dropped it. The new input keeps the artifact contents the same as before.

Rebased onto main at ab6e086 on 2026-10-12. No conflicts. Main added lint.yml with actions/checkout@v4, so it is bumped here too. Every uses: line in .github/workflows/ is now on a Node 24 major.

Checks

  • Confirmed the runs.using value at each tag with the GitHub API, and that the major tags exist (checkout's latest release is v7.0.1).
  • Parsed the three edited workflows as YAML.
  • lint.yml runs on this PR, so its checkout bump is exercised by this PR's own checks.
  • deploy-pages.yml and upstream-watch.yml only run from main, so they are validated after merge.

Noticed, not fixed

  • .nojekyll has no effect for an Actions-based Pages deployment, so the include-hidden-files line could be dropped along with the file. I left both in place to keep this change minimal.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The workflow does not preserve .nojekyll as described.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates the GitHub Pages workflow to Node 24-compatible GitHub Actions releases.

Changes:

  • Upgrades checkout, Pages configuration, artifact upload, and deployment actions.
  • The required hidden-file preservation input is missing, so .nojekyll will be excluded.
File Summary
.github/​workflows/​deploy-pages.yml Updates Pages deployment action versions; add include-hidden-files: true or revise the .nojekyll intent.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/deploy-pages.yml
@Project516
Project516 force-pushed the project516/actions-node24 branch 3 times, most recently from 1524c9f to cb4ec95 Compare October 1, 2026 20:08
@Project516
Project516 force-pushed the project516/actions-node24 branch from cb4ec95 to 82cf738 Compare October 12, 2026 22:40
@Project516

Copy link
Copy Markdown
Member Author

@allengregoryiv ready for a review when you have a moment. Rebased onto main at ab6e086 today. Main's new lint.yml was still on actions/checkout@v4, so it's bumped here too, and the lint check passed with it.

@SpectrumFRC3847
SpectrumFRC3847 merged commit 56cb953 into Spectrum3847:main Oct 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants