Repository navigation
Upstream watch: skip prereleases and record reviewed tags - #12
Merged
SpectrumFRC3847 merged 1 commit intoOct 15, 2026
Merged
SpectrumFRC3847 merged 1 commit into
SpectrumFRC3847 merged 1 commit into
Conversation
This was referenced Oct 1, 2026
Project516
force-pushed
the
project516/upstream-watch-reviewed
branch
from
October 1, 2026 20:08
cf456b5 to
3d2f159
Compare
…onVision and allwpilib tags
Project516
force-pushed
the
project516/upstream-watch-reviewed
branch
from
October 12, 2026 22:40
3d2f159 to
cfc2f73
Compare
Member
Author
|
@allengregoryiv ready for a review when you have a moment. Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The weekly upstream watch opened #8 and #10 for versions that need no action. This records them as reviewed, so the next run closes both issues and only reopens them for something newer.
v2026.7is PhotonVision's April Fools release (prerelease, published 2026-04-01, nine days beforev2026.3.4).version_keyranked it abovev2026.3.4because 7 > 3.PV_NEXT_REVIEWED=v2027.0.0-alpha-2inscripts/ci/upstream-pins.env. alpha-2 is the robot's PhotonLib already. The Jetson's move to 2027 is Document WPILib 2027 alpha-7 migration limits #1 and Experimental alpha-7 CUDA and PhotonVision migration #2.ALLWPILIB_REVIEWED=v2026.2.2.04-build-allwpilib.shmust match the PhotonVision fork'swpilibVersion, which is2026.2.1atd8c9e8e, so bumping the tag alone would split the detector from PhotonVision's own WPILib.v2026.2.1...v2026.2.2changes nowpiutilorapriltagfiles. Inwpimathit only touchesPoseEstimator,PoseEstimator3dandSlewRateLimiter, which the detector does not use.Closes #8
Closes #10
Rebased onto
mainatab6e086on 2026-10-12. No conflicts. #14 also editsupstream_watch.py(the L4T check) and merges with this cleanly.Checks
python3 -m py_compile scripts/ci/upstream_watch.pyandscripts/ci/lint.sh, both clean.report_photonvision()andreport_allwpilib()against the live GitHub API: both return nothing with the new pins. With the pins set back one step (v2027.0.0-alpha-1,v2026.2.1), they reportv2027.0.0-alpha-2andv2026.2.2with the new hint, andv2026.7no longer appears.